healthcheck: set appropriate defaults for interval, timeout and retries
#225
Conversation
Set appropriate defaults from interval, timeout and retries when processing a Containerfile with build format as docker. See: https://docs.docker.com/engine/reference/builder/#healthcheck Closes: containers/podman#13912 Signed-off-by: Aditya R <[email protected]>
|
@flouthoc: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
The new test Dockerfile should also be added to the |
| Test: []string{"CMD-SHELL", "/app/check.sh --quiet"}, | ||
| }, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
I'm probably overthinking, but I just wonder if we're starting to brush up against DockerHub rate limits. No need to adjust, just thought I'd put that thought out there.
There was a problem hiding this comment.
We tend to use one of a handful of base images for various tests, and the docker daemon hangs on to them between tests, but you're not wrong to be concerned that it will become a problem at some point.
|
LGTM, once @nalind 's concerns are addressed. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
It is documented here https://docs.docker.com/engine/reference/builder/#healthcheck that I have also verified this against conformance tests so this PR must not go in and alt is: containers/podman#13928 |
Set appropriate defaults for
--interval,--timeoutand--retrieswhenprocessing a Containerfile with build format as docker.
See: https://docs.docker.com/engine/reference/builder/#healthcheck
Closes: containers/podman#13912