Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.14] OCPBUGS-19794: Upgrade Agent APIs to v1beta1 #3059

Merged
merged 2 commits into from
Oct 10, 2023
Merged

[release-4.14] OCPBUGS-19794: Upgrade Agent APIs to v1beta1 #3059

merged 2 commits into from
Oct 10, 2023

Conversation

CrystalChun
Copy link
Contributor

What this PR does / why we need it:
Cluster-api-provider Agent has updated its APIs to v1beta1 from v1alpha1, so hypershift will need to use these new versions.
Cherry-pick of #3022 & #3050

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes OCPBUGS-19794
OCPBUGS-19516
MGMT-14838

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-merge-robot @CrystalChun
Merge pull request openshift#3022 from CrystalChun/upgrade-agent
aa87999 
OCPBUGS-19516: Upgrade agent APIs to v1beta1
@openshift-merge-robot @CrystalChun
Merge pull request openshift#3050 from CrystalChun/fix-crd
958e002 
OCPBUGS-19784: Update capi agent version for CRD label
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Sep 28, 2023
@openshift-ci-robot
Copy link

@CrystalChun: This pull request references Jira Issue OCPBUGS-19794, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-19516 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-19516 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
  • bug has dependents

Requesting review from QA contact:
/cc @LiangquanLi930

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What this PR does / why we need it:
Cluster-api-provider Agent has updated its APIs to v1beta1 from v1alpha1, so hypershift will need to use these new versions.
Cherry-pick of #3022 & #3050

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes OCPBUGS-19794
OCPBUGS-19516
MGMT-14838

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bryan-cox
Copy link
Member

/area cli
/area ci-tooling
/area hypershift-operator

@openshift-ci openshift-ci bot added area/cli Indicates the PR includes changes for CLI area/ci-tooling Indicates the PR includes changes for CI or tooling area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release and removed do-not-merge/needs-area labels Sep 28, 2023
@openshift-ci openshift-ci bot requested review from enxebre and sjenning September 28, 2023 15:29
@CrystalChun
Copy link
Contributor Author

/retest

2 similar comments
@CrystalChun
Copy link
Contributor Author

/retest

@CrystalChun
Copy link
Contributor Author

/retest

@CrystalChun
Copy link
Contributor Author

/cc @eranco74 @filanov

@openshift-ci openshift-ci bot requested review from eranco74 and filanov September 29, 2023 23:15
@CrystalChun CrystalChun mentioned this pull request Sep 29, 2023
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 30, 2023

@CrystalChun: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ibmcloud-iks 958e002 link false /test e2e-ibmcloud-iks
ci/prow/e2e-ibmcloud-roks 958e002 link false /test e2e-ibmcloud-roks

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@eranco74
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2023
@enxebre
Copy link
Member

enxebre commented Oct 2, 2023 •
edited
Loading

/approve
/hold
to confirm https://issues.redhat.com//browse/OCPBUGS-19516 has been verified.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 2, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CrystalChun, enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2023
@CrystalChun
Copy link
Contributor Author

I've successfully tested out and verified https://issues.redhat.com//browse/OCPBUGS-19516 against existing clusters

@CrystalChun
Copy link
Contributor Author

/unhold

Already verified by QE

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 9, 2023
@openshift-ci-robot
Copy link

@CrystalChun: This pull request references Jira Issue OCPBUGS-19794, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-19516 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-19516 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
  • bug has dependents

Requesting review from QA contact:
/cc @LiangquanLi930

In response to this:

What this PR does / why we need it:
Cluster-api-provider Agent has updated its APIs to v1beta1 from v1alpha1, so hypershift will need to use these new versions.
Cherry-pick of #3022 & #3050

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes OCPBUGS-19794
OCPBUGS-19516
MGMT-14838

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@CrystalChun
Copy link
Contributor Author

/retest-required

@openshift-ci-robot openshift-ci-robot mentioned this pull request Oct 10, 2023
Merged
@enxebre
Copy link
Member

enxebre commented Oct 10, 2023

/override "Red Hat Trusted App Pipeline / hypershift-release-414-on-pull-request"

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2023

@enxebre: Overrode contexts on behalf of enxebre: Red Hat Trusted App Pipeline / hypershift-release-414-on-pull-request

In response to this:

/override "Red Hat Trusted App Pipeline / hypershift-release-414-on-pull-request"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b06a68a and 2 for PR HEAD 958e002 in total

@openshift-ci openshift-ci bot merged commit 6c9318e into openshift:release-4.14 Oct 10, 2023
@openshift-ci-robot
Copy link

@CrystalChun: Jira Issue OCPBUGS-19794: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-19794 has been moved to the MODIFIED state.

In response to this:

What this PR does / why we need it:
Cluster-api-provider Agent has updated its APIs to v1beta1 from v1alpha1, so hypershift will need to use these new versions.
Cherry-pick of #3022 & #3050

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes OCPBUGS-19794
OCPBUGS-19516
MGMT-14838

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.14.0-0.nightly-2023-10-12-104602

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiangquanLi930 LiangquanLi930 Awaiting requested review from LiangquanLi930

@enxebre enxebre Awaiting requested review from enxebre

@sjenning sjenning Awaiting requested review from sjenning

@eranco74 eranco74 Awaiting requested review from eranco74

@filanov filanov Awaiting requested review from filanov

Assignees

@eranco74 eranco74

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ci-tooling Indicates the PR includes changes for CI or tooling area/cli Indicates the PR includes changes for CLI area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@CrystalChun @openshift-ci-robot @bryan-cox @eranco74 @enxebre @openshift-merge-robot