Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: list provider states in a separate place #829

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

jrichter1
Copy link
Contributor

Fixes

https://issues.redhat.com/browse/HAC-5212

Description

Make pact provider states available in a single place for visibility

@openshift-ci openshift-ci bot requested review from rottencandy and sahil143 October 5, 2023 13:24
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 5, 2023

@jrichter1: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #829 (5d4ecb2) into main (e77e123) will increase coverage by 0.02%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #829      +/-   ##
==========================================
+ Coverage   85.20%   85.22%   +0.02%     
==========================================
  Files         586      587       +1     
  Lines       14416    14492      +76     
  Branches     4029     4050      +21     
==========================================
+ Hits        12283    12351      +68     
- Misses       2001     2009       +8     
  Partials      132      132              

see 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e77e123...5d4ecb2. Read the comment docs.

@jrichter1
Copy link
Contributor Author

/retest

3 similar comments
@jrichter1
Copy link
Contributor Author

/retest

@jrichter1
Copy link
Contributor Author

/retest

@jrichter1
Copy link
Contributor Author

/retest

@Katka92
Copy link
Contributor

Katka92 commented Oct 9, 2023

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jrichter1, Katka92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2023
@Katka92
Copy link
Contributor

Katka92 commented Oct 9, 2023

/retest

@openshift-ci openshift-ci bot merged commit d2b4bd1 into openshift:main Oct 9, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants