fix(OverviewPage): remomve NamepspacedPage wrapper from Overview page

openshift · Jun 4, 2024 · eee873d · eee873d
1 parent e1546f7
commit eee873d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/components/NamespacedPage/NamespacedPage.tsx b/src/components/NamespacedPage/NamespacedPage.tsx
@@ -15,11 +15,13 @@ import './NamespacedPage.scss';
 type NamespacedPageProps = {
   children: React.ReactNode;
   hideAppBanner?: boolean;
+  skipWorkspaceCheck?: boolean;
 };
 
 const NamespacedPage: React.FunctionComponent<React.PropsWithChildren<NamespacedPageProps>> = ({
   children,
   hideAppBanner,
+  skipWorkspaceCheck = false,
 }) => {
   const { workspacesLoaded } = React.useContext(WorkspaceContext);
 
@@ -33,7 +35,7 @@ const NamespacedPage: React.FunctionComponent<React.PropsWithChildren<Namespaced
     }
   }, []);
 
-  if (!workspacesLoaded) {
+  if (!skipWorkspaceCheck && !workspacesLoaded) {
     return (
       <Bullseye>
         <Spinner />

diff --git a/src/pages/OverviewPage.tsx b/src/pages/OverviewPage.tsx
@@ -9,7 +9,7 @@ import { FULL_APPLICATION_TITLE } from '../consts/labels';
 
 const OverviewPage: React.FC<React.PropsWithChildren<unknown>> = () => {
   return (
-    <NamespacedPage hideAppBanner>
+    <NamespacedPage hideAppBanner skipWorkspaceCheck>
       <Helmet>
         <title>Overview | {FULL_APPLICATION_TITLE}</title>
       </Helmet>