OCPBUGS-13978: bump k8s modules to 0.27.4

[alebedev87]

Bump of k8s.io/[email protected]. [email protected] bump was mandatory as it's the first version supporting k8s api >=0.27.x.

Changes related to [email protected]:

• Manager options changed:
  • NewClient changed the signature and the cache handling
  • Namespace and MultiNamespaceCacheBuilder are deprecated now, Cache field was used instead
• WithStatusSubresource method has to be used in the fake client if the status is expected to be updated
• source.Kind is not public anymore
• sigs.k8s.io/controller-runtime/pkg/envtest/printer package has been removed
• webhook.Validator interface changed the signature of its methods

Also golangci-lint (part of verify job) has been updated with the staticcheck and gosimple linters which are suggested to be default. The staticcheck found some deprecated methods:

• https://pkg.go.dev/k8s.io/apimachinery/pkg/util/wait deprecated a lot of PollX methods in favor of the context aware alternatives.
• k8s.io/utils/pointer deprecated all the methods with Ptr in the name in favor of the methods without it

[openshift-ci-robot]

@alebedev87: This pull request references Jira Issue OCPBUGS-13978, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @ShudiLi

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bump of k8s.io/[email protected]. [email protected] bump was mandatory as it's the first version supporting k8s api >=0.27.x.

Changes related to [email protected]:

• Manager options changed:
• NewClient changed the signature and the cache handling
• Namespace and MultiNamespaceCacheBuilder are deprecated now, Cache field was used instead
• WithStatusSubresource method has to be used in the fake client if the status is expected to be updated
• source.Kind is not public anymore
• sigs.k8s.io/controller-runtime/pkg/envtest/printer package has been removed
• webhook.Validator interface changed the signature of its methods

Also golangci-lint (part of verify job) has been updated with the staticcheck and gosimple linters which are suggested to be default. The staticcheck found some deprecated methods:

• https://pkg.go.dev/k8s.io/apimachinery/pkg/util/wait deprecated a lot of PollX methods in favor of the context aware alternatives.
• k8s.io/utils/pointer deprecated all the methods with Ptr in the name in favor of the methods without it

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [alebedev87]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[alebedev87]

/assign @gcs278

[gcs278]

Reviewed and have no issues.
/lgtm

[gcs278]

/lgtm cancel
actually, I have one comment...sorry.

[gcs278]

0.27.3 is out, https://pkg.go.dev/k8s.io/api?tab=versions

Should we use the latest?

[alebedev87]

Meantime they released 0.27.4, so I bumped to it. Hope they'll not release any new before we decide to merge the PR :)

[openshift-ci-robot]

@alebedev87: This pull request references Jira Issue OCPBUGS-13978, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @ShudiLi

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bump of k8s.io/[email protected]. [email protected] bump was mandatory as it's the first version supporting k8s api >=0.27.x.

Changes related to [email protected]:

• Manager options changed:
• NewClient changed the signature and the cache handling
• Namespace and MultiNamespaceCacheBuilder are deprecated now, Cache field was used instead
• WithStatusSubresource method has to be used in the fake client if the status is expected to be updated
• source.Kind is not public anymore
• sigs.k8s.io/controller-runtime/pkg/envtest/printer package has been removed
• webhook.Validator interface changed the signature of its methods

Also golangci-lint (part of verify job) has been updated with the staticcheck and gosimple linters which are suggested to be default. The staticcheck found some deprecated methods:

• https://pkg.go.dev/k8s.io/apimachinery/pkg/util/wait deprecated a lot of PollX methods in favor of the context aware alternatives.
• k8s.io/utils/pointer deprecated all the methods with Ptr in the name in favor of the methods without it

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[gcs278]

Should this be bumped to 0.27.4 too?

[alebedev87]

I think so, weird it wasn't bumped as a dependency.

[gcs278]

I feel bad for commenting this...https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.15.1

Thnk we should bump?

[alebedev87]

Seems to be a bug fix release, let me try.

[openshift-ci-robot]

@alebedev87: This pull request references Jira Issue OCPBUGS-13978, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @ShudiLi

In response to this:

Bump of k8s.io/[email protected]. [email protected] bump was mandatory as it's the first version supporting k8s api >=0.27.x.

Changes related to [email protected]:

• Manager options changed:
• NewClient changed the signature and the cache handling
• Namespace and MultiNamespaceCacheBuilder are deprecated now, Cache field was used instead
• WithStatusSubresource method has to be used in the fake client if the status is expected to be updated
• source.Kind is not public anymore
• sigs.k8s.io/controller-runtime/pkg/envtest/printer package has been removed
• webhook.Validator interface changed the signature of its methods

Also golangci-lint (part of verify job) has been updated with the staticcheck and gosimple linters which are suggested to be default. The staticcheck found some deprecated methods:

• https://pkg.go.dev/k8s.io/apimachinery/pkg/util/wait deprecated a lot of PollX methods in favor of the context aware alternatives.
• k8s.io/utils/pointer deprecated all the methods with Ptr in the name in favor of the methods without it

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[gcs278]

Sorry for the delays.
/lgtm

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 0cd8bee and 2 for PR HEAD cc366fc in total

[openshift-ci]

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@alebedev87: Jira Issue OCPBUGS-13978: All pull requests linked via external trackers have merged:

• openshift/external-dns-operator#194

Jira Issue OCPBUGS-13978 has been moved to the MODIFIED state.

In response to this:

Bump of k8s.io/[email protected]. [email protected] bump was mandatory as it's the first version supporting k8s api >=0.27.x.

Changes related to [email protected]:

• Manager options changed:
• NewClient changed the signature and the cache handling
• Namespace and MultiNamespaceCacheBuilder are deprecated now, Cache field was used instead
• WithStatusSubresource method has to be used in the fake client if the status is expected to be updated
• source.Kind is not public anymore
• sigs.k8s.io/controller-runtime/pkg/envtest/printer package has been removed
• webhook.Validator interface changed the signature of its methods

Also golangci-lint (part of verify job) has been updated with the staticcheck and gosimple linters which are suggested to be default. The staticcheck found some deprecated methods:

• https://pkg.go.dev/k8s.io/apimachinery/pkg/util/wait deprecated a lot of PollX methods in favor of the context aware alternatives.
• k8s.io/utils/pointer deprecated all the methods with Ptr in the name in favor of the methods without it

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.