Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster High-availability Mode API #555

Merged

Conversation

dhellmann
Copy link
Contributor

@dhellmann dhellmann commented Dec 2, 2020

As we add more deployment topologies for OpenShift, we need a way to
communicate expectations to the operators managing the cluster. This
enhancement describes an API for telling operators how hard they
should work to provide high-availability.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2020
@dhellmann
Copy link
Contributor Author

@dhellmann
Copy link
Contributor Author

/cc @eranco74

@dhellmann
Copy link
Contributor Author

/cc @lilic

@dhellmann
Copy link
Contributor Author

/cc @cgwalters

Copy link
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for writing this!

@romfreiman
Copy link

@danwinship @dcbw @alexanderConstantinescu we should explore using this api for that assisted installer flow in 4.8 (2 nodes that become 3 later on).

Copy link
Contributor

@lilic lilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @simonpasquier @bbrowning for 👀 on the monitoring side of things

@openshift-ci-robot openshift-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2020
@dhellmann dhellmann requested review from cgwalters and lilic December 4, 2020 19:57
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, derekwaynecarr, markmc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [derekwaynecarr,markmc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dhellmann
Copy link
Contributor Author

@dhellmann I had debated if SingleNode should be SingleReplica or just Single , but as it turns out there isn't a great term for the opposite of HA that fits everywhere. The only nit with Node suffix is that we are describing how to schedule pods at the end of the day. I don't think its worth bike-shedding over, but just remarking here if you wanted to update later.

/approve
/lgtm

I could go along with changing it to SingleReplica. I'll send another PR.

@openshift-merge-robot openshift-merge-robot merged commit 2d83963 into openshift:master Jan 13, 2021
ravidbro pushed a commit to ravidbro/api that referenced this pull request Jan 14, 2021
ravidbro pushed a commit to ravidbro/api that referenced this pull request Jan 14, 2021
ravidbro pushed a commit to ravidbro/api that referenced this pull request Jan 14, 2021
ravidbro pushed a commit to ravidbro/api that referenced this pull request Jan 14, 2021
ravidbro pushed a commit to ravidbro/api that referenced this pull request Jan 17, 2021
ravidbro pushed a commit to ravidbro/api that referenced this pull request Jan 17, 2021
ravidbro pushed a commit to ravidbro/api that referenced this pull request Jan 18, 2021
ravidbro pushed a commit to ravidbro/api that referenced this pull request Jan 18, 2021
ravidbro pushed a commit to ravidbro/api that referenced this pull request Jan 26, 2021
ravidbro pushed a commit to ravidbro/api that referenced this pull request Jan 26, 2021
ravidbro pushed a commit to ravidbro/api that referenced this pull request Jan 27, 2021
ravidbro pushed a commit to ravidbro/api that referenced this pull request Jan 28, 2021
eranco74 pushed a commit to eranco74/installer that referenced this pull request Feb 8, 2021
ravidbro pushed a commit to ravidbro/installer that referenced this pull request Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.