vSphere IPI Support for Static IPs

[rvanderp3]

cc: @JoelSpeed, @elmiko, @patrickdillon, @jcpowermac, @cybertron, @zaneb

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[mtulio]

@rvanderp3 Overall LGTM. A few nit comments and lint failing fixes.

[rvanderp3]

/override markdownlint

[openshift-ci]

@rvanderp3: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

• markdownlint

Only the following failed contexts/checkruns were expected:

• ci/prow/markdownlint
• pull-ci-openshift-enhancements-master-markdownlint

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override markdownlint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mtulio]

/lgtm

[patrickdillon]

/approve

[patrickdillon]

/retest

[rvanderp3]

/hold
/skip markdownlint

[2uasimojo]

Nothing blocking from my side assuming my understanding of hive's day 0 approach is correct. Whether/how hive will support this via MachinePools is out of scope, but looks doable based on what I see here.

Otherwise, just nits and questions.

/approve

[2uasimojo]

Is static IP support on the roadmap for you?

We're trying to do as little as we can get away with in this space until we know how the CAPI transition is going to shake out for us. That said...

For day 0 we accept the install-config as an opaque blob and pass it through. Since it appears possible to do this new thing with just install-config (i.e. you don't have to hand-edit manifests* -- right?) I think we can have day 0 support for free.

For day 2, we'll need to figure out how/whether (hive) MachinePools will be supported.

• If yes, we would need to figure out how to allow the user to plumb the new addressesFromPools through. (And we'll need to address how that IPAddressPool is managed; probably punted to however the user sees fit -- possibly from the hub via syncsets, but otherwise directly on the spoke.)
• If no, we either have to document "no support" and let things break organically if the user tries to use MachinePools with this feature; or, if that organic breakage is really terrible, try to discover whether static IPs are in play (by parsing the install-config -- is there another way?) and forbid MachinePools proactively.

*We do have a code path to muck with the generated machineset manifests for a couple of (specific, hardcoded) things. But it would be nice to avoid adding more to that if possible.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo, patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• enhancements/network/OWNERS [2uasimojo,patrickdillon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rvanderp3]

/test markdownlint

[vr4manta]

/lgtm

[JoelSpeed]

/lgtm

[rvanderp3]

/hold cancel

[JoelSpeed]

Spoke with @rvanderp3 , looks like the template changed mid way through this one
/override ci/prow/markdownlint

[openshift-ci]

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/markdownlint

In response to this:

Spoke with @rvanderp3 , looks like the template changed mid way through this one
/override ci/prow/markdownlint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@rvanderp3: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.