Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating es manifest to allow it to watch all namespaces #74

Merged
merged 1 commit into from
Jan 29, 2019
Merged

Updating es manifest to allow it to watch all namespaces #74

merged 1 commit into from
Jan 29, 2019

Conversation

ewolinetz
Copy link
Contributor

Part of work for ES per namespace hackfest item for Jaeger integration
Note that this is not installed via OLM in the same way so that means a normal OLM installation will not give the Elasticsearch Operator full cluster watch authz

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2019
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 29, 2019
@pavolloffay pavolloffay mentioned this pull request Jan 29, 2019
Closed
jcantrill
jcantrill approved these changes Jan 29, 2019
View reviewed changes
Copy link
Contributor

@jcantrill jcantrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

josefkarasek
josefkarasek approved these changes Jan 29, 2019
View reviewed changes
Copy link

@josefkarasek josefkarasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ewolinetz, jcantrill, josefkarasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ewolinetz,jcantrill,josefkarasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@josefkarasek
Copy link

@ewolinetz should our tests or makefile be updated?

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit b580d2f into openshift:master Jan 29, 2019
@ewolinetz
Copy link
Contributor Author

@josefkarasek it might be helpful to do that so we can verify that it is able to create an ES cluster in any namespace and help us from regressing our permissions. I can do a follow up so we use a "random" namespace for the test.

@ewolinetz ewolinetz deleted the es_operator_all_namespace branch December 1, 2020 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josefkarasek josefkarasek josefkarasek approved these changes

@jcantrill jcantrill jcantrill approved these changes

@richm richm Awaiting requested review from richm

@lukas-vlcek lukas-vlcek Awaiting requested review from lukas-vlcek

Assignees

@jcantrill jcantrill

@josefkarasek josefkarasek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ewolinetz @openshift-bot @openshift-ci-robot @josefkarasek @jcantrill @openshift-merge-robot