-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1883719: Bulk statistics are recorded under index threadpool #511
Conversation
@lukas-vlcek: This pull request references Bugzilla bug 1883719, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@lukas-vlcek: This pull request references Bugzilla bug 1883719, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Heads up @mburke5678 I think we have documented individual alerts for Elasticsearch somewhere. If this PR gets merged we will need to update |
@lukas-vlcek: This pull request references Bugzilla bug 1883719, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@lukas-vlcek did you run a cluster and verify the new queries? |
/bugzilla refresh |
@jcantrill: This pull request references Bugzilla bug 1883719, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
Not really, I had issues building EO image locally this week. But this is simple change I do not expect this should break anything even if the metric name is invalid. |
/uncc @periklis |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I created a cluster and verified these metrics exist and the rules record
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: blockloop, jcantrill, lukas-vlcek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@lukas-vlcek: All pull requests linked via external trackers have merged: Bugzilla bug 1883719 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Bulk threadpool was renamed to index. See elastic/elasticsearch#29593
/assign @blockloop
https://bugzilla.redhat.com/show_bug.cgi?id=1883719