-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1801339: Rebase to upstream 1.6.6 #22
Bug 1801339: Rebase to upstream 1.6.6 #22
Conversation
….1 (coredns#3114) Bumps [gopkg.in/DataDog/dd-trace-go.v1](https://github.com/DataDog/dd-trace-go) from 1.16.0 to 1.16.1. - [Release notes](https://github.com/DataDog/dd-trace-go/releases) - [Commits](DataDog/dd-trace-go@v1.16.0...v1.16.1) Signed-off-by: dependabot-preview[bot] <[email protected]>
…redns#3116) Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.21.2 to 1.22.3. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Changelog](https://github.com/aws/aws-sdk-go/blob/master/CHANGELOG.md) - [Commits](aws/aws-sdk-go@v1.21.2...v1.22.3) Signed-off-by: dependabot-preview[bot] <[email protected]>
Just building in master updates the deps. Pushing this as a PR to get a clean build back. Signed-off-by: Miek Gieben <[email protected]>
In the setup function use plugin.Error() to wrap the errors with the plugin name. Because there isn't a separate setup() function this is done for all returned errors. Remove *upstream.Upstream from the New parameters as this is always set and adjust the tests to account for this. Signed-off-by: Miek Gieben <[email protected]>
Add notes for next release; azure was merged, nice to get that out, some other bugfixes. Signed-off-by: Miek Gieben <[email protected]>
format and simplify; highlighted some stuff in route53_test.go that could be further simplified. Signed-off-by: Miek Gieben <[email protected]>
Say a thing about 1.12.8 and HTTP/2 Signed-off-by: Miek Gieben <[email protected]>
Signed-off-by: Miek Gieben <[email protected]>
Just minor textual cleanup.
Signed-off-by: Palash Nigam <[email protected]> Closes: coredns#2822
Looks like there were some leftover in PR 3011 during the merge conflict rebase. This PR removes the unneeded file and fixed the plugin.cfg Signed-off-by: Yong Tang <[email protected]>
…s#3138) This PR adds some content in clouddns plugin to mention about the fact that privately hosted zone does not need to attach to a VPC. Also change PROJECT_NAME to PROJECTT_ID, and reformt the markdown to replace tab with 4 whitespace. Signed-off-by: Yong Tang <[email protected]>
* plugin/clouddns: tiny fixes for the README Did a post-merge review. Fix a few typos. Signed-off-by: Miek Gieben <[email protected]> * Naming; coredns -> CoreDNS clouddns -> Cloud DNS and italics then the plugin's name are mentioned. Signed-off-by: Miek Gieben <[email protected]>
This feature introduce continuous fuzzing with the following features: * Ruzzing: fuzz-targets are run continuously on master ( the fuzzers are updated every time new code is pushed to master) * Regresion: In addition to unit-tests travis runs all fuzz targets through the generated corpus to catch bugs early on in the CI process before merge.
* Remove federation Signed-off-by: Yong Tang <[email protected]> * Rebuild and point to github.com/coredns/federation Signed-off-by: Yong Tang <[email protected]> * Export `localNodeName` => `LocalNodeName`, to be used by federation (until deprecation) Signed-off-by: Yong Tang <[email protected]> * Remove plugin/kubernetes/federation.go (=> kubernetes/federation repo) Signed-off-by: Yong Tang <[email protected]> * Update github.com/coredns/federation Signed-off-by: Yong Tang <[email protected]> * sticker-ci fix Signed-off-by: Yong Tang <[email protected]>
Since we use golang 1.12 and gomod, it is not necessary to match the impor path to `/go/src/github.com/coredns/coredns` in order to build coredns. For that reason the build command inside docker could be simplified with: ``` $ docker run --rm -i -t -v $PWD:/v -w /v golang:1.12 make ``` Signed-off-by: Yong Tang <[email protected]>
* fuzz: some cleanups Signed-off-by: Miek Gieben <[email protected]> * smaller Signed-off-by: Miek Gieben <[email protected]> * documentation Signed-off-by: Miek Gieben <[email protected]> * comments Signed-off-by: Miek Gieben <[email protected]>
…oredns#3148) Bumps [github.com/caddyserver/caddy](https://github.com/caddyserver/caddy) from 1.0.1 to 1.0.3. - [Release notes](https://github.com/caddyserver/caddy/releases) - [Commits](caddyserver/caddy@v1.0.1...v1.0.3) Signed-off-by: dependabot-preview[bot] <[email protected]>
Bumps [github.com/Azure/go-autorest/autorest](https://github.com/Azure/go-autorest) from 0.8.0 to 0.9.0. - [Release notes](https://github.com/Azure/go-autorest/releases) - [Changelog](https://github.com/Azure/go-autorest/blob/master/CHANGELOG.md) - [Commits](Azure/go-autorest@autorest/v0.8.0...autorest/v0.9.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
…3154) Bumps [google.golang.org/api](https://github.com/google/google-api-go-client) from 0.7.0 to 0.8.0. - [Release notes](https://github.com/google/google-api-go-client/releases) - [Changelog](https://github.com/googleapis/google-api-go-client/blob/master/CHANGES.md) - [Commits](googleapis/google-api-go-client@v0.7.0...v0.8.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
/assign @celebdor @ironcladlou @cybertron @frobware |
@bcrochet: GitHub didn't allow me to assign the following users: cybertron, frobware, celebdor. Note that only openshift members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@bcrochet: GitHub didn't allow me to request PR reviews from the following users: celebdor, cybertron, frobware. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ca3b3ab
to
c36d112
Compare
[bcrochet@bcrochet coredns]$ podman build -f Dockerfile.openshift . Image build is working locally. |
/retest |
Previous coredns versions had a `make test` target and our ci-operator currently uses this target to kick off the tests. So, at least to get tests running against this PR without requiring changes to the openshift/release ci-operator setup, I'm adding that target back. This just runs the full litany of tests that Travis would run except for the coverage targets and the tests that require a running etcd server.
The coredns exclusion in .gitignore was ignoring anything that was named coredns. This patch makes it specifically just the binary in the main dir.
…lugin This plugin allows for discovering hosts via mDNS browsing, which means that those nodes are then exposed via normal unicast DNS.
c36d112
to
b5ab269
Compare
…esses with zone (coredns#3527) 1. The HostPortOrFile tests don't have any IPv6 tests. This adds some. 2. The HostPortOrFile breaks if any of the addresses have IPv6 zone defined. ParseIP does not handle %zone anymore. Signed-off-by: Brad P. Crochet <[email protected]>
b5ab269
to
358bd8f
Compare
/approve |
/retest |
/retest |
@ironcladlou @bcrochet This PR included some fixes we need for IPv6. Do you want to propose a backport of the whole rebase? or cherry-pick the specific things needed for IPv6? |
I think we should backport the rebase to ease future backports, @bcrochet what do you think? Seems like it should merge cleanly? |
@bcrochet: All pull requests linked via external trackers have merged. Bugzilla bug 1801339 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The PR was created by first taking upstream/v1.6.6 (tag) as the base then applying
UPSTREAM: <carry>
patches on top. The set of patches applied was taken from:To create the merge commit I have used the following steps:
For details on the
merge^{tree}
syntax please read this documentation.The result of
git commit-tree
in this PR is 0858c65I then applied all the carry commits on top. Some patches were dropped, because they were referencing old vendored code, and Gopkg.*. A single vendor commit was created to be replaced in future rebases.
As we have not used this method prior, I have added the
UPSTREAM: <carry>: openshift
prefix to those commits that did not have this convention. This will make it easier to identify carry commits for the next rebase.