Update caddy import to use the one from coredns #73
Conversation
openshift-ci-robot
added
the
approved
cybertron
force-pushed
the
caddy-import
branch
from
7a6edd6 to
2cb0b98
Compare
go.mod
Outdated
| golang.org/x/time v0.0.0-20210220033141-f8bda1e9f3ba // indirect | ||
| gopkg.in/yaml.v2 v2.4.0 // indirect | ||
| k8s.io/api v0.20.4 // indirect | ||
| k8s.io/client-go v11.0.0+incompatible // indirect |
There was a problem hiding this comment.
is this version tag for client-go right?
There was a problem hiding this comment.
It looks like I passed an errant -u to go get when I updated coredns. I think this should be fixed now.
When caddy moved to v2, coredns chose to stay with v1 by moving it in-tree. Plugins need to update their imports to reflect this. Note that this will fail the build-coredns ci job until the openshift/coredns repo has been updated to the new version. I have tested it locally with a newer version and it works.
cybertron
force-pushed
the
caddy-import
branch
from
2cb0b98 to
088b281
Compare
|
@cybertron: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
For reference, this is in relation to coredns/coredns#4018 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bcrochet, cybertron The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Update `go.mod`, `go.sum`, and `vendor/` after the v1.8.1 rebase. This commit picks up openshift/coredns-mdns#73 which migrates openshift/coredns-mdns to use coredns v1.8.1.
When caddy moved to v2, coredns chose to stay with v1 by moving it
in-tree. Plugins need to update their imports to reflect this.
Note that this will fail the build-coredns ci job until the
openshift/coredns repo has been updated to the new version. I have
tested it locally with a newer version and it works.