Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove height on .co-ns-selector to fix bg color bug on catalog at mo… #638

Closed
wants to merge 1 commit into from

Conversation

rhamilto
Copy link
Member

@rhamilto rhamilto commented Oct 10, 2018

…bile

Before:
console apps ui-preserve origin-gce dev openshift com_k8s_cluster_projects iphone 6_7_8 plus

After:
localhost_9000_catalog_all-namespaces iphone 6_7_8 plus

Note: changes in #603 still result in the namespace picker bar fading on on some route changes. I gather this is a bandaid to minimize the fact the picker is loading after the rest of the page, but the late load of the picker seems undesirable. http://recordit.co/NBO3QtOZcf

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 10, 2018
@spadgett
Copy link
Member

I think we should just disable the animation for now. It's a little jarring for it to pop in on initial page load, but it's fine switching between nav items. I'm not sure the fade-in on every route change is really better.

@rhamilto
Copy link
Member Author

In testing this further, it's not clear why it's even necessary to hide and then show the picker. @alecmerdler, can you clarify why it was added?

cc: @sg00dwin

@spadgett
Copy link
Member

@rhamilto I believe it needs to wait for API discovery to complete before we can show the picker. We're keying on whether there's a Project resource.

@spadgett
Copy link
Member

We should be able to avoid any flicker when switching routes, however.

@rhamilto
Copy link
Member Author

Closing in favor of #639

@rhamilto rhamilto closed this Oct 10, 2018
@rhamilto rhamilto deleted the co-ns-selector-fix branch October 12, 2018 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants