Don't download geckodriver when CHROME_VERSION is defined #5882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spadgett
reviewed
Jul 2, 2020
rhrazdil
force-pushed
the
disable-gecko-when-chrome-version
branch
from
3d2428e to
fe3807f
Compare
spadgett
reviewed
Jul 2, 2020
quote condition test-gui.sh Co-authored-by: Sam Padgett <[email protected]>
rhrazdil
force-pushed
the
disable-gecko-when-chrome-version
branch
from
865a3a8 to
affeaa7
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhrazdil, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In CNV Jenkins CI we're too often hitting problem with webdriver-update failing to download geckodriver because of exceeding allowed number of unauthenticated requests to github API.
webdriver-managed will support authentication only in version 13 according to angular/webdriver-manager#216 (comment)
I think it would make sense to set
--gecko=falsein case CHROME_VERSION is explicitly defined, as Firefox is presumably not being used.