OCPBUGS-47722: always show associated plugin name on CSV details page #14656

yapei · 2025-01-03T08:20:52Z

Since we are showing Console plugin section only when csvPlugins.length > 0 and we are aiming to always present console plugin name on CSV details page, so removed csvPluginsCount from ConsolePlugins

              {csvPlugins.length > 0 && subscription && (
                <ConsolePlugins
                  csvPlugins={csvPlugins}
                  trusted={isCatalogSourceTrusted(subscription?.spec?.source)}
                />
              )}

Since we are trying to always show console plugin name in Console Plugin Modal, so also removed csvPluginsCount from ConsolePluginModal
Always show plugin name on CSV details page regardless of plugin count
Always show plugin name in plugin modal regardless of plugin count

openshift-ci-robot · 2025-01-03T08:20:57Z

@yapei: This pull request references Jira Issue OCPBUGS-47222, which is invalid:

expected the vulnerability to target either version "4.19." or "openshift-4.19.", but it targets "4.15.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Since we are showing Console plugin section only when csvPlugins.length > 0 and we are aiming to always present console plugin name on CSV details page, so removed csvPluginsCount from ConsolePlugins
             {csvPlugins.length > 0 && subscription && (
               <ConsolePlugins
                 csvPlugins={csvPlugins}
                 trusted={isCatalogSourceTrusted(subscription?.spec?.source)}
               />
             )}
Since we are trying to always show console plugin name in Console Plugin Modal, so also removed csvPluginsCount from ConsolePluginModal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

rhamilto

/approve
/lgtm

Thanks, @yapei! Nice work.

rhamilto · 2025-01-10T18:01:34Z

/retest

rhamilto · 2025-01-10T21:04:28Z

/retest

yapei · 2025-01-20T01:34:38Z

/retest-required

yapei · 2025-01-20T07:40:18Z

/retest-required

openshift-ci-robot · 2025-01-20T09:36:24Z

@yapei: This pull request references Jira Issue OCPBUGS-47722, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.19.0) matches configured target version for branch (4.19.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Since we are showing Console plugin section only when csvPlugins.length > 0 and we are aiming to always present console plugin name on CSV details page, so removed csvPluginsCount from ConsolePlugins
             {csvPlugins.length > 0 && subscription && (
               <ConsolePlugins
                 csvPlugins={csvPlugins}
                 trusted={isCatalogSourceTrusted(subscription?.spec?.source)}
               />
             )}
Since we are trying to always show console plugin name in Console Plugin Modal, so also removed csvPluginsCount from ConsolePluginModal

Always show plugin name on CSV details page regardless of plugin count

Always show plugin name in plugin modal regardless of plugin count

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2025-01-20T09:36:43Z

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: yapei.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@yapei: This pull request references Jira Issue OCPBUGS-47722, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)

bug target version (4.19.0) matches configured target version for branch (4.19.0)

bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.
In response to this:
Since we are showing Console plugin section only when csvPlugins.length > 0 and we are aiming to always present console plugin name on CSV details page, so removed csvPluginsCount from ConsolePlugins
             {csvPlugins.length > 0 && subscription && (
               <ConsolePlugins
                 csvPlugins={csvPlugins}
                 trusted={isCatalogSourceTrusted(subscription?.spec?.source)}
               />
             )}
Since we are trying to always show console plugin name in Console Plugin Modal, so also removed csvPluginsCount from ConsolePluginModal

Always show plugin name on CSV details page regardless of plugin count

Always show plugin name in plugin modal regardless of plugin count
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

yapei · 2025-01-20T13:08:46Z

/retest-required

rhamilto · 2025-01-20T14:07:08Z

frontend/packages/operator-lifecycle-manager/src/components/clusterserviceversion.tsx


  return (
    <>
      {consoleOperatorConfig && canPatchConsoleOperatorConfig && (
        <dl className="co-clusterserviceversion-details__field">
-          <dt>{t('olm~Console plugin', { count: csvPluginsCount })}</dt>
+          <dt>{t('olm~Console plugin')}</dt>


We still want the pluralization if there are more than one?

yes, you are right
updated~

yapei · 2025-01-21T07:34:51Z

/hold

yapei · 2025-01-24T07:22:00Z

/hold cancel

yapei · 2025-01-24T07:24:35Z

show plugin name when there is only one associated plugin

yapei · 2025-01-24T11:42:25Z

/test e2e-gcp-console

yapei · 2025-01-24T11:42:47Z

@rhamilto May I have another review?

rhamilto · 2025-01-24T13:10:39Z

frontend/packages/console-shared/src/components/modals/ConsolePluginModal.tsx

      </ModalTitle>
      <ModalBody>
        <p>
-          {csvPluginsCount


I think we want to keep the ternary here so the verbiage is more precise since the modal can be launched from either the CSV details page or the Dynamic Plugins list page.

yapei · 2025-01-26T05:42:32Z

Single plugin

More plugins

yapei · 2025-01-27T02:27:28Z

/test e2e-gcp-console

openshift-ci · 2025-01-27T07:01:56Z

@yapei: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	`51842e2`	link	false	`/test okd-scos-e2e-aws-ovn`
ci/prow/e2e-gcp-console	`51842e2`	link	true	`/test e2e-gcp-console`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

rhamilto · 2025-01-27T12:34:28Z

/lgtm

/hold for #14621

openshift-ci · 2025-01-27T12:35:13Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, yapei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/operator-lifecycle-manager/OWNERS~~ [rhamilto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci bot requested review from spadgett and TheRealJon January 3, 2025 08:22

openshift-ci bot added component/olm Related to OLM component/shared Related to console-shared kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Jan 3, 2025

rhamilto approved these changes Jan 10, 2025

View reviewed changes

openshift-ci bot assigned rhamilto Jan 10, 2025

openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 10, 2025

yapei changed the title ~~OCPBUGS-47222: always show associated plugin name on CSV details page~~ OCPBUGS-47722: always show associated plugin name on CSV details page Jan 20, 2025

openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 20, 2025

yapei force-pushed the ocpbugs-47722 branch from ab189ed to a1b95d5 Compare January 20, 2025 09:39

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2025

rhamilto reviewed Jan 20, 2025

View reviewed changes

yapei force-pushed the ocpbugs-47722 branch from a1b95d5 to 3c6320c Compare January 21, 2025 06:15

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 21, 2025

yapei force-pushed the ocpbugs-47722 branch from 3c6320c to ab9eb2f Compare January 24, 2025 07:19

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2025

rhamilto reviewed Jan 24, 2025

View reviewed changes

yapei force-pushed the ocpbugs-47722 branch from ab9eb2f to 8835d86 Compare January 26, 2025 02:48

OCPBUGS-47722: always show associated plugin name on CSV details page

51842e2

yapei force-pushed the ocpbugs-47722 branch from 8835d86 to 51842e2 Compare January 26, 2025 02:50

openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Jan 27, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OCPBUGS-47722: always show associated plugin name on CSV details page #14656

OCPBUGS-47722: always show associated plugin name on CSV details page #14656

yapei commented Jan 3, 2025 •

edited

Loading

openshift-ci-robot commented Jan 3, 2025

rhamilto left a comment

rhamilto commented Jan 10, 2025

rhamilto commented Jan 10, 2025

yapei commented Jan 20, 2025

yapei commented Jan 20, 2025

openshift-ci-robot commented Jan 20, 2025

openshift-ci bot commented Jan 20, 2025

yapei commented Jan 20, 2025

rhamilto Jan 20, 2025

yapei Jan 21, 2025

yapei commented Jan 21, 2025

yapei commented Jan 24, 2025

yapei commented Jan 24, 2025

yapei commented Jan 24, 2025

yapei commented Jan 24, 2025

rhamilto Jan 24, 2025

yapei Jan 26, 2025

yapei commented Jan 26, 2025

yapei commented Jan 27, 2025

openshift-ci bot commented Jan 27, 2025

rhamilto commented Jan 27, 2025

openshift-ci bot commented Jan 27, 2025

OCPBUGS-47722: always show associated plugin name on CSV details page #14656

Are you sure you want to change the base?

OCPBUGS-47722: always show associated plugin name on CSV details page #14656

Conversation

yapei commented Jan 3, 2025 • edited Loading

openshift-ci-robot commented Jan 3, 2025

rhamilto left a comment

Choose a reason for hiding this comment

rhamilto commented Jan 10, 2025

rhamilto commented Jan 10, 2025

yapei commented Jan 20, 2025

yapei commented Jan 20, 2025

openshift-ci-robot commented Jan 20, 2025

openshift-ci bot commented Jan 20, 2025

yapei commented Jan 20, 2025

rhamilto Jan 20, 2025

Choose a reason for hiding this comment

yapei Jan 21, 2025

Choose a reason for hiding this comment

yapei commented Jan 21, 2025

yapei commented Jan 24, 2025

yapei commented Jan 24, 2025

yapei commented Jan 24, 2025

yapei commented Jan 24, 2025

rhamilto Jan 24, 2025

Choose a reason for hiding this comment

yapei Jan 26, 2025

Choose a reason for hiding this comment

yapei commented Jan 26, 2025

yapei commented Jan 27, 2025

openshift-ci bot commented Jan 27, 2025

rhamilto commented Jan 27, 2025

openshift-ci bot commented Jan 27, 2025

yapei commented Jan 3, 2025 •

edited

Loading