OCPVE-673: Bump API to Add OLM Capability #971
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@eggfoobar: This pull request references OCPVE-673 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
do-not-merge/hold
eggfoobar
force-pushed
the
add-capability-olm
branch
from
07ecf28 to
1e07d00
Compare
eggfoobar
force-pushed
the
add-capability-olm
branch
from
1e07d00 to
03af581
Compare
openshift-merge-robot
added
the
needs-rebase
|
@eggfoobar: This pull request references OCPVE-673 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
eggfoobar
force-pushed
the
add-capability-olm
branch
from
03af581 to
197aa6d
Compare
openshift-merge-robot
removed
the
needs-rebase
|
@eggfoobar: This pull request references OCPVE-673 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/unhold API change was merged in |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@eggfoobar: This pull request references OCPVE-673 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
eggfoobar
force-pushed
the
add-capability-olm
branch
from
197aa6d to
85edb55
Compare
|
@eggfoobar: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
eggfoobar
force-pushed
the
add-capability-olm
branch
from
85edb55 to
a315e94
Compare
eggfoobar
changed the title
eggfoobar
force-pushed
the
add-capability-olm
branch
2 times, most recently
from
06d0a8d to
9e7be2f
Compare
|
/assign @petr-muller This should be good now for a review |
|
/retest-required |
|
/hold for validation |
openshift-ci
bot
added
the
do-not-merge/hold
|
@eggfoobar: This pull request references OCPVE-673 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/unhold The addition in CVO was validated to work with ClusterBot, after we had resolved some image-registry errors, the pipeline now looks better. However, because of the addition of I'll unblock openshift/origin#28302 since the CI for no-cap runs weekly, that change should get in before the CI runs. Merging this PR, will unblock: Ran: |
openshift-ci
bot
removed
the
do-not-merge/hold
Signed-off-by: ehila <[email protected]>
removed deprecated ConfigMapsLeasesResourceLock to new LeasesResourceLock Signed-off-by: ehila <[email protected]>
Signed-off-by: ehila <[email protected]>
eggfoobar
force-pushed
the
add-capability-olm
branch
from
9e7be2f to
1a32029
Compare
|
/lgtm |
|
Rolling back capability addition from the ClusterVersion CRD is known to break the ability of the CVO to write the no-longer-recognized capability string to /override ci/prow/e2e-agnostic-ovn-upgrade-out-of-change ClusterBot testing looks good and openshift/origin#28302 has merged. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, eggfoobar, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@wking: Overrode contexts on behalf of wking: ci/prow/e2e-agnostic-ovn-upgrade-out-of-change In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
approved
|
@eggfoobar: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@wking the next time(if there is a next time) we run into that i think we will drop the status validation, even if only temporarily, wdyt? |
|
what does "if only temporarily" mean? Do we bump the API repo, vendor bump here, and try and remember to vendor-bump again with enum re-tightening once we get past branch-fork? Or can we just drop the |
we wouldn't need to get past branch fork, just until we have a nightly that doesn't include the reverted cap name so upgrades don't fail, right? but yes, more or less that's what temporarily would mean. and with "if only temporarily" i was trying to convey "at that point we'd decide if we wanted to only do it temporarily, or convince ourselves to drop them permanently" |
|
I've opened openshift/api#1624 floating "drop the enum from |
Bump API to add OLM capability
/hold
Holding until API change is merged in openshift/api#1589