OCPBUGS-46584: Adjust Workload Hints test cases based on Intel or AMD #1258
Conversation
mrniranjan
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@mrniranjan: This pull request references Jira Issue OCPBUGS-46584, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-bug
|
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: mrniranjan. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| if isIntel { | ||
| Expect(cmdline).To(ContainSubstring("intel_pstate=passive")) | ||
| Expect(cmdline).ToNot(ContainSubstring("intel_pstate=active")) | ||
| } else { |
There was a problem hiding this comment.
Would isAMD be more descriptive with an else that throws an error? Just in case we get ARM machines in the future?
There was a problem hiding this comment.
Ack, i will add it
There was a problem hiding this comment.
fixed in the latest commit
|
/retest-required |
mrniranjan
force-pushed
the
check_cpu_vendor
branch
2 times, most recently
from
50ded99 to
9d47c77
Compare
|
/retest-required |
We use lscpu output and check Vendor ID to determine if the system is AMD or Intel. Signed-off-by: Niranjan M.R <[email protected]>
Adjust Workload Hints E2E test cases to verify kernel parameters depending on the Vendor in the case of x86_64 where kernel args are changed based on Intel or AMD. Signed-off-by: Niranjan M.R <[email protected]>
Signed-off-by: Niranjan M.R <[email protected]>
mrniranjan
force-pushed
the
check_cpu_vendor
branch
from
c91d8aa to
b8cf664
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MarSik, mrniranjan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/label acknowledge-critical-fixes-only test only change |
openshift-ci
bot
added
the
acknowledge-critical-fixes-only
|
@yanirq sorry, i am adding a hold due to a bug in my patch |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
remove duplicate intel_pstate=passive from kernelParameters string slice as it's already added if system is intel Signed-off-by: Niranjan M.R <[email protected]>
|
New changes are detected. LGTM label has been removed. |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
This PR adds utility functions to get Cpu Vendor (intel or AMD) in case of x86_64.
Also Adjust Workload Hints test cases where kernel Args are adjusted based on Intel or AMD.