OCPBUGS-46496: [release-4.16] Add vendor and architecture specific tuning options #1254
Conversation
…hift#1083) * CNF-14090: Add vendor and architecture specific tuning options - Performance tuning support for 3 platforms (amd/x86,arm/aarch64,intel/x86) is added in this change - When a valid platform is detected the additional platform specific tuning will be imported alongside the default tuning - This makes use of a new helper function added to tuned to detect the system name and architecture - Update unit tests to account for the various changes - Add new unit tests to cover the platform specific tuning * CNF-14090: Re-sync e2e test yaml for tuning changes * CNF-14090: Use variable composition for idle_poll - idle=poll is only supported on x86 - Update tests to account for changes - Add explaination comments to empty values in openshift-node-performance * CNF-14090: Re-sync e2e test yaml for tuning changes * CNF-14090: Fix active/passive pstates * CNF-14090: Re-sync e2e test yaml for tuning changes
* OCPBUGS-43665: Drop amd_iommu=on from amd tuning - "=on" is not a valid value for amd_iommu - amd_iommu is enabled by default unless you specify "amd_iommu=off", unlike intel - See kernel docs for more information (https://docs.kernel.org/admin-guide/kernel-parameters.html) * OCPBUGS-43665: Update render-sync for performance profile change
* Fix kernel arguments ordering on Intel An upgrade from previous version causes one extra reboot due to differently ordered kernel arguments. This is a side effect of platform specific tuned profile split we merged in openshift#1083 This fix updates the Intel specific tuned profile to follow the same ordering that was used in the past. It does so by exploiting a specific tuned behavior of the bootloader plugin. It orders the kernel argument cmdline_suffix keys based on the order of first appearance. Any additional appearance just changes the value, but not the ordering. The change is only needed for Intel, because we have never supported other platforms before and so upgrade is not an issue. * Sync rendered manifests
|
@openshift-cherrypick-robot: An error was encountered searching for bug OCPBUGS-43664 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details. Full error message.
No response returned: Get "https://issues.redhat.com/rest/api/2/issue/OCPBUGS-43664": GET https://issues.redhat.com/rest/api/2/issue/OCPBUGS-43664 giving up after 5 attempt(s)
Please contact an administrator to resolve this issue, then request a bug refresh with In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label backport-risk-assessed |
openshift-ci
bot
added
the
backport-risk-assessed
|
/retest-required |
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MarSik, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/jira cherry-pick release-4.16 |
|
/retitle OCPBUGS-46496: [release-4.16] Add vendor and architecture specific tuning options |
openshift-ci
bot
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-46496, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@MarSik: This pull request references Jira Issue OCPBUGS-46496, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@mrniranjan: This pull request references Jira Issue OCPBUGS-46496, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label cherry-pick-approved |
openshift-ci
bot
added
the
cherry-pick-approved
openshift-merge-bot
bot
merged commit 3d784aa
into
openshift:release-4.16
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-46496: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-46496 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: cluster-node-tuning-operator |
|
Fix included in accepted release 4.16.0-0.nightly-2024-12-23-104316 |
This is an automated cherry-pick of #1191
/assign MarSik