Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-45264: Normalize cpu sets when rendering to Tuned profiles #1232

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

MarSik
Copy link
Contributor

@MarSik MarSik commented Dec 2, 2024

Previously the isolated cpu list was passed verbatim as the user entered it. This could have resulted in very long kernel command line.

Example: 10,9,8,7,6,5,4,3,2,1 (imagine 500+ cpus)

This change consolidates the parsing logic in the Tuned templating and generates simply the following in such case.

Example: 1-10

Previously the isolated cpu list was passed verbatim as the user
entered it. This could have resulted in very long kernel command
line.

Example: 10,9,8,7,6,5,4,3,2,1 (imagine 500+ cpus)

This change consolidates the parsing logic in the Tuned templating
and generates simply the following in such case.

Example: 1-10
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Dec 2, 2024
@openshift-ci-robot
Copy link
Contributor

@MarSik: This pull request references Jira Issue OCPBUGS-45264, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mrniranjan

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Previously the isolated cpu list was passed verbatim as the user entered it. This could have resulted in very long kernel command line.

Example: 10,9,8,7,6,5,4,3,2,1 (imagine 500+ cpus)

This change consolidates the parsing logic in the Tuned templating and generates simply the following in such case.

Example: 1-10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Dec 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MarSik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2024
@MarSik
Copy link
Contributor Author

MarSik commented Dec 3, 2024

/retest-required

@jmencak
Copy link
Contributor

jmencak commented Dec 3, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 7d54582 and 2 for PR HEAD b25aa76 in total

Copy link
Contributor

openshift-ci bot commented Dec 3, 2024

@MarSik: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn b25aa76 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 7d54582 and 2 for PR HEAD b25aa76 in total

@openshift-merge-bot openshift-merge-bot bot merged commit 350b36b into openshift:master Dec 3, 2024
16 of 17 checks passed
@openshift-ci-robot
Copy link
Contributor

@MarSik: Jira Issue OCPBUGS-45264: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-45264 has been moved to the MODIFIED state.

In response to this:

Previously the isolated cpu list was passed verbatim as the user entered it. This could have resulted in very long kernel command line.

Example: 10,9,8,7,6,5,4,3,2,1 (imagine 500+ cpus)

This change consolidates the parsing logic in the Tuned templating and generates simply the following in such case.

Example: 1-10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: cluster-node-tuning-operator
This PR has been included in build cluster-node-tuning-operator-container-v4.19.0-202412040145.p0.g350b36b.assembly.stream.el9.
All builds following this will include this PR.

@MarSik
Copy link
Contributor Author

MarSik commented Dec 4, 2024

/cherry-pick release-4.18 release-4.17 release-4.16

@openshift-cherrypick-robot

@MarSik: new pull request created: #1238

In response to this:

/cherry-pick release-4.18 release-4.17 release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants