-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-45264: Normalize cpu sets when rendering to Tuned profiles #1232
Conversation
Previously the isolated cpu list was passed verbatim as the user entered it. This could have resulted in very long kernel command line. Example: 10,9,8,7,6,5,4,3,2,1 (imagine 500+ cpus) This change consolidates the parsing logic in the Tuned templating and generates simply the following in such case. Example: 1-10
@MarSik: This pull request references Jira Issue OCPBUGS-45264, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MarSik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
/lgtm |
@MarSik: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
350b36b
into
openshift:master
@MarSik: Jira Issue OCPBUGS-45264: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-45264 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] Distgit: cluster-node-tuning-operator |
/cherry-pick release-4.18 release-4.17 release-4.16 |
@MarSik: new pull request created: #1238 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Previously the isolated cpu list was passed verbatim as the user entered it. This could have resulted in very long kernel command line.
Example: 10,9,8,7,6,5,4,3,2,1 (imagine 500+ cpus)
This change consolidates the parsing logic in the Tuned templating and generates simply the following in such case.
Example: 1-10