OCPBUGS-42365: E2E: Adjusted mixed_cpus suite for hypershift

[SargunNarula]

• Performance Profile applying is made consistent with mcp and nodepool based environments
• Removed deprecated API client.
• Added test suite run in makefile

[openshift-ci-robot]

@SargunNarula: This pull request references Jira Issue OCPBUGS-42365, which is invalid:

• expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

• Performance Profile applying is made consistent with mcp and nodepool based environments
• Removed deprecated API client.
• Added test suite run in makefile

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[SargunNarula]

/jira refresh

[openshift-ci-robot]

@SargunNarula: This pull request references Jira Issue OCPBUGS-42365, which is invalid:

• expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[SargunNarula]

/jira refresh

[openshift-ci-robot]

@SargunNarula: This pull request references Jira Issue OCPBUGS-42365, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.18.0) matches configured target version for branch (4.18.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[SargunNarula]

/retest

[SargunNarula]

/retest

[SargunNarula]

/retest

[SargunNarula]

/retest

[SargunNarula]

/retest

[Tal-or]

We don't have a lane that runs HyperShift + TechPreview featuregate enable. So why are we modifying those tests in the first place?

[SargunNarula]

We don't have a lane that runs HyperShift + TechPreview featuregate enable. So why are we modifying those tests in the first place?

Currently, we don't have a lane enabled. However, we can plan to have this built as part of the future developments. Alternatively, we can focus on keeping the tests updated with support, which will help accelerate the effort whenever the lane is eventually available. @Tal-or @mrniranjan

[Tal-or]

lint error:

s: 272.126µs, source_code: 60.951µs, cgo: 8.84µs, invalid_issue: 5.5µs, filename_unadjuster: 3.44µs, max_same_issues: 3.03µs, uniq_by_line: 2.05µs, max_from_linter: 1.04µs, path_shortener: 810ns, max_per_file_from_linter: 450ns, diff: 360ns, skip_files: 340ns, fixer: 230ns, exclude: 210ns, sort_results: 210ns, path_prefixer: 90ns, severity-rules: 80ns"
level=info msg="[runner] linters took 26.793436469s with stages: goanalysis_metalinter: 26.78682303s"
test/e2e/performanceprofile/functests/11_mixedcpus/mixedcpus.go:548:70: `intial` is a misspelling of `initial` (misspell)
		By(fmt.Sprintf("executing teardown - revert profile %q back to its intial state", profile.Name))
		                                                                   ^
test/e2e/performanceprofile/functests/11_mixedcpus/mixedcpus.go:752:1: unnecessary trailing newline (whitespace)

[Tal-or]

We don't have a lane that runs HyperShift + TechPreview featuregate enable. So why are we modifying those tests in the first place?

Currently, we don't have a lane enabled. However, we can plan to have this built as part of the future developments. Alternatively, we can focus on keeping the tests updated with support, which will help accelerate the effort whenever the lane is eventually available. @Tal-or @mrniranjan

My concern is that when we'll enable the lane one day, the test will break, did we test it locally?

[SargunNarula]

We don't have a lane that runs HyperShift + TechPreview featuregate enable. So why are we modifying those tests in the first place?

Currently, we don't have a lane enabled. However, we can plan to have this built as part of the future developments. Alternatively, we can focus on keeping the tests updated with support, which will help accelerate the effort whenever the lane is eventually available. @Tal-or @mrniranjan

My concern is that when we'll enable the lane one day, the test will break, did we test it locally?

Yes, I did test this PR locally, by enabling the TechPreview featuregate on a hypershift environment. I have shared the d/s test run results with you via slack.

[mrniranjan]

We don't have a lane that runs HyperShift + TechPreview featuregate enable. So why are we modifying those tests in the first place?

Currently, we don't have a lane enabled. However, we can plan to have this built as part of the future developments. Alternatively, we can focus on keeping the tests updated with support, which will help accelerate the effort whenever the lane is eventually available. @Tal-or @mrniranjan

My concern is that when we'll enable the lane one day, the test will break, did we test it locally?

@Tal-or If it's a hard requirement to have a lane, I can enable the feature in Downstream,

[Tal-or]

Good job,
we're almost there, please address the my last comments and i'll approve

[Tal-or]

/lgtm

Thank you for your hard work

[yanirq]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SargunNarula, yanirq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [yanirq]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[SargunNarula]

/retest-required

[SargunNarula]

/retest-required

[openshift-ci]

@SargunNarula: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	fd22db0	link	false	/test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[Tal-or]

/acknowledge-critical-fixes-only

Testing only. Not part of payload

[yanirq]

/label acknowledge-critical-fixes-only

[openshift-ci-robot]

@SargunNarula: Jira Issue OCPBUGS-42365: All pull requests linked via external trackers have merged:

• openshift/cluster-node-tuning-operator#1173

Jira Issue OCPBUGS-42365 has been moved to the MODIFIED state.

In response to this:

• Performance Profile applying is made consistent with mcp and nodepool based environments
• Removed deprecated API client.
• Added test suite run in makefile

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: cluster-node-tuning-operator
This PR has been included in build cluster-node-tuning-operator-container-v4.19.0-202412230909.p0.g1fbe1ee.assembly.stream.el9.
All builds following this will include this PR.