OCPBUGS-28647: deferred updates: cleanups

[ffromani]

cleanups suggested late in the #1019 cycle or emerged after the first nightly CI run

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ffromani]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jmencak]

Thank you for the cleanup. This looks good to me, but letting other reviewers comment. Only one super-nit:

diff --git a/pkg/tuned/controller.go b/pkg/tuned/controller.go
index cce3334a..561a60dc 100644
--- a/pkg/tuned/controller.go
+++ b/pkg/tuned/controller.go
@@ -403,7 +403,7 @@ type ExtractedProfiles struct {
 
 // ProfilesExtract extracts TuneD daemon profiles to tunedProfilesDirCustom directory.
 // Returns:
-//   - ExtractedProfile with the details of the operation performed
+//   - ExtractedProfiles with the details of the operation performed.
 //   - Error if any or nil.
 func ProfilesExtract(profiles []tunedv1.TunedProfile, recommendedProfile string) (ExtractedProfiles, error) {
 	klog.Infof("profilesExtract(): extracting %d TuneD profiles (recommended=%s)", len(profiles), recommendedProfile)

[ffromani]

Thank you for the cleanup. This looks good to me, but letting other reviewers comment. Only one super-nit:

diff --git a/pkg/tuned/controller.go b/pkg/tuned/controller.go
index cce3334a..561a60dc 100644
--- a/pkg/tuned/controller.go
+++ b/pkg/tuned/controller.go
@@ -403,7 +403,7 @@ type ExtractedProfiles struct {
 
 // ProfilesExtract extracts TuneD daemon profiles to tunedProfilesDirCustom directory.
 // Returns:
-//   - ExtractedProfile with the details of the operation performed
+//   - ExtractedProfiles with the details of the operation performed.
 //   - Error if any or nil.
 func ProfilesExtract(profiles []tunedv1.TunedProfile, recommendedProfile string) (ExtractedProfiles, error) {
 	klog.Infof("profilesExtract(): extracting %d TuneD profiles (recommended=%s)", len(profiles), recommendedProfile)

thanks, fixed

[ffromani]

/cc @Tal-or
as he did most of the comments I'm addressing here

[Tal-or]

@ffromani I don't see where the actual skip is done?
We should have something like this:
https://github.com/openshift/cluster-node-tuning-operator/blob/master/Makefile#L260C135-L260C162
Am I missing something here?

[ffromani]

@ffromani I don't see where the actual skip is done? We should have something like this: https://github.com/openshift/cluster-node-tuning-operator/blob/master/Makefile#L260C135-L260C162 Am I missing something here?

because is not yet :) I'll still need to do the skipping part consuming the labels

[ffromani]

/hold

incomplete PR

[ffromani]

/hold cancel

xref: https://github.com/openshift/release/blob/master/ci-operator/config/openshift/cluster-node-tuning-operator/openshift-cluster-node-tuning-operator-master.yaml#L119

[Tal-or]

/lgtm
Thanks!

[ffromani]

/hold

[ffromani]

/unhold

before the latest update:

$ make test-e2e
for d in deferred; do \
  KUBERNETES_CONFIG="/home/fromani/clusters/cnflab/kubeconfig" GOOS=linux GO111MODULE=on GOFLAGS=-mod=vendor go test -v -timeout 40m ./test/e2e/$d -ginkgo.v -ginkgo.no-color -ginkgo.fail-fast -ginkgo.label-filter=\"!flaky\" || exit; \
done
=== RUN   TestNodeTuningOperatorDeferred
Ginkgo detected configuration issues:
Syntax Error Parsing Label Filter
  "!flaky"
  Invalid token '!'.

  Learn more at: http://onsi.github.io/ginkgo/#spec-labels
FAIL	github.com/openshift/cluster-node-tuning-operator/test/e2e/deferred	0.021s
FAIL
make: *** [Makefile:103: test-e2e] Error 1

[ffromani]

/retest

[Tal-or]

The label is Flaky (begin with capital letter) but the filter is !flaky (small letter).
Are you sure it would match the label?

[ffromani]

The label is Flaky (begin with capital letter) but the filter is !flaky (small letter). Are you sure it would match the label?

good catch. Partial update. Fixing.

[ffromani]

uhm, kube standard is to use Capitalized nouns, but the rest of the tests is using lowercase-dash-separated

[Tal-or]

/lgtm
Thank you for the fixes

[ffromani]

thank you for the careful review! low caffeine intake today

[jmencak]

New changes are detected. LGTM label has been removed.

Thank you @ffromani , the last change was requested by me.

/lgtm

[openshift-ci-robot]

@ffromani: This pull request references Jira Issue OCPBUGS-28647, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.17.0) matches configured target version for branch (4.17.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @shajmakh

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

cleanups suggested late in the #1019 cycle or emerged after the first nightly CI run

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ffromani]

/jira refresh

[openshift-ci-robot]

@ffromani: This pull request references Jira Issue OCPBUGS-28647, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.17.0) matches configured target version for branch (4.17.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @shajmakh

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@ffromani: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@ffromani: Jira Issue OCPBUGS-28647: Some pull requests linked via external trackers have merged:

• openshift/cluster-node-tuning-operator#1073
• openshift/cluster-node-tuning-operator#1019

The following pull requests linked via external trackers have not merged:

• openshift/cluster-node-tuning-operator#1118 is open

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-28647 has not been moved to the MODIFIED state.

In response to this:

cleanups suggested late in the #1019 cycle or emerged after the first nightly CI run

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: cluster-node-tuning-operator
This PR has been included in build cluster-node-tuning-operator-container-v4.18.0-202407232010.p0.ga869242.assembly.stream.el9.
All builds following this will include this PR.