NO-JIRA: makefile: ensure bindata #1116
Conversation
0_config requires now `pkg/manifests`, so we need to make sure bindata is generated Signed-off-by: Francesco Romani <[email protected]>
openshift-ci
bot
added
the
approved
|
/label acknowledge-critical-fixes-only if CI passes, this change can't break the product |
openshift-ci
bot
added
the
acknowledge-critical-fixes-only
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ffromani, jmencak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
|
/retest-required |
|
@ffromani: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-ci-robot
added
the
jira/valid-reference
|
@ffromani: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@ffromani: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: cluster-node-tuning-operator |
Since [1], cluster-node-tuning operator needs a compile step to run functional tests. Though a general refactor in how we run submodules functional tests would be required at this point, this commit fix the problem in the short term by invoking `make vet` right after the checkout. [1] openshift/cluster-node-tuning-operator#1116 Signed-off-by: Andrea Panattoni <[email protected]>
Since [1], cluster-node-tuning operator needs a compile step to run functional tests. Though a general refactor in how we run submodules functional tests would be required at this point, this commit fix the problem in the short term by invoking `make vet` right after the checkout. [1] openshift/cluster-node-tuning-operator#1116 Signed-off-by: Andrea Panattoni <[email protected]>
Since [1], cluster-node-tuning operator needs a compile step to run functional tests. Though a general refactor in how we run submodules functional tests would be required at this point, this commit fix the problem in the short term by invoking `make vet` right after the checkout. [1] openshift/cluster-node-tuning-operator#1116 Signed-off-by: Andrea Panattoni <[email protected]>
0_config requires now
pkg/manifests, so we needto make sure bindata is generated
extracted from #1019 because it helps other PRs too: #1019 (comment) (xref: #1089)