Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-34972: perfprof: bump verbosiness of logs #1075

Merged
merged 1 commit into from
Jun 11, 2024
Merged

OCPBUGS-34972: perfprof: bump verbosiness of logs #1075

merged 1 commit into from
Jun 11, 2024

Conversation

ffromani
Copy link
Contributor

@ffromani ffromani commented Jun 6, 2024

Increase the verbosiness required to emit log messages to reduce the log amount.
Note this change doesn't address the reason for periodic reconciles, we only review the verbosiness of log messages.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 6, 2024
@openshift-ci-robot
Copy link
Contributor

@ffromani: This pull request references Jira Issue OCPBUGS-34972, which is invalid:

  • expected the bug to target the "4.17.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Increase the verbosiness required to emit log messages to reduce the log amount.
Note this change doesn't address the reason for periodic reconciles, we only review the verbosiness of log messages.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from kpouget and yanirq June 6, 2024 14:29
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2024
@ffromani
Copy link
Contributor Author

ffromani commented Jun 7, 2024

/retest

@ffromani
OCPBUGS-34972: perfprof: bump verbosiness of logs
503decb 
Increase the verbosiness required to emit log messages to
reduce the log amount.
Note this change doesn't address the reason for periodic reconciles,
we only review the verbosiness of log messages.

Signed-off-by: Francesco Romani <[email protected]>
@ffromani ffromani force-pushed the silent-performance-controller branch from 9a68553 to 503decb Compare June 10, 2024 08:47
@ffromani
Copy link
Contributor Author

/retest

1 similar comment
@ffromani
Copy link
Contributor Author

/retest

@ffromani
Copy link
Contributor Author

/retest-required

@ffromani
Copy link
Contributor Author

/cc @MarSik @Tal-or

@openshift-ci openshift-ci bot requested review from MarSik and Tal-or June 11, 2024 09:32
MarSik
MarSik approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@MarSik MarSik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, MarSik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ffromani
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jun 11, 2024
@openshift-ci-robot
Copy link
Contributor

@ffromani: This pull request references Jira Issue OCPBUGS-34972, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mrniranjan

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jun 11, 2024
@openshift-ci openshift-ci bot requested a review from mrniranjan June 11, 2024 11:21
@ffromani
Copy link
Contributor Author

/retest-required

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 11, 2024

@ffromani: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 6de4dca into openshift:master Jun 11, 2024
16 checks passed
@openshift-ci-robot
Copy link
Contributor

@ffromani: Jira Issue OCPBUGS-34972: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-34972 has been moved to the MODIFIED state.

In response to this:

Increase the verbosiness required to emit log messages to reduce the log amount.
Note this change doesn't address the reason for periodic reconciles, we only review the verbosiness of log messages.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.17.0-202406111842.p0.g6de4dca.assembly.stream.el9 for distgit cluster-node-tuning-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarSik MarSik MarSik approved these changes

@kpouget kpouget Awaiting requested review from kpouget

@yanirq yanirq Awaiting requested review from yanirq

@Tal-or Tal-or Awaiting requested review from Tal-or

@mrniranjan mrniranjan Awaiting requested review from mrniranjan

Assignees

@MarSik MarSik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ffromani @openshift-ci-robot @openshift-bot @MarSik