Skip to content

Commit

Permalink
E2E: Add test to verify runc uses valid cpus
Browse files Browse the repository at this point in the history
Adding a test to verify that runc does not use CPUs assigned to guaranteed pods.

Signed-off-by: Sargun Narula <[email protected]>
  • Loading branch information
SargunNarula committed Sep 27, 2024
1 parent ae57af1 commit 083325f
Showing 1 changed file with 96 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -887,8 +887,104 @@ var _ = Describe("[rfe_id:27363][performance] CPU Management", Ordered, func() {
})
})

Context("Check container runtimes cpu usage", func() {
var guaranteedPod, bestEffortPod *corev1.Pod
AfterEach(func() {
By("Cleaning up pods")
deleteTestPod(ctx, guaranteedPod)
deleteTestPod(ctx, bestEffortPod)
})
It("[test_id: 74461] Verify that runc excludes the cpus used by guaranteed pod", func() {
By("Creating a guaranteed pod")
guaranteedPod := makePod(ctx, workerRTNode, true)
err := testclient.Client.Create(ctx, guaranteedPod)
Expect(err).ToNot(HaveOccurred(), "Failed to create guaranteed pod")

By("Waiting for guaranteed pod to be ready")
_, err = pods.WaitForCondition(ctx, client.ObjectKeyFromObject(guaranteedPod), corev1.PodReady, corev1.ConditionTrue, 5*time.Minute)
Expect(err).ToNot(HaveOccurred(), "Guaranteed pod did not become ready in time")
Expect(guaranteedPod.Status.QOSClass).To(Equal(corev1.PodQOSGuaranteed), "Guaranteed pod does not have the correct QOSClass")

By("Creating a best-effort pod")
bestEffortPod := makePod(ctx, workerRTNode, false)
err = testclient.Client.Create(ctx, bestEffortPod)
Expect(err).ToNot(HaveOccurred(), "Failed to create best-effort pod")

By("Waiting for best-effort pod to be ready")
_, err = pods.WaitForCondition(ctx, client.ObjectKeyFromObject(bestEffortPod), corev1.PodReady, corev1.ConditionTrue, 5*time.Minute)
Expect(err).ToNot(HaveOccurred(), "Best-effort pod did not become ready in time")
containerIDs := make([]string, 2)

By("Fetching container ID for guaranteed pod")
containerIDs[0], err = pods.GetContainerIDByName(guaranteedPod, "test")
Expect(err).ToNot(HaveOccurred(), "Failed to get container ID for guaranteed pod")

By("Fetching container ID for best-effort pod")
containerIDs[1], err = pods.GetContainerIDByName(bestEffortPod, "test")
Expect(err).ToNot(HaveOccurred(), "Failed to get container ID for best-effort pod")
var configData string

By("Reading config.json for both containers")
for _, containerID := range containerIDs {
path := fmt.Sprintf("/rootfs/var/run/containers/storage/overlay-containers/%s/userdata/config.json", containerID)
cmd := []string{"/bin/bash", "-c", fmt.Sprintf("cat %s", path)}
output, err := nodes.ExecCommand(ctx, workerRTNode, cmd)
Expect(err).ToNot(HaveOccurred(), fmt.Sprintf("Failed to read config.json for container ID: %s", containerID))
configData += testutils.ToString(output)
}

By("Extracting hostname and cpus information from config data")
hostnameRe := regexp.MustCompile(`"hostname":\s+"([^"]+)"`)
cpusRe := regexp.MustCompile(`"cpus":\s+"([^"]+)"`)
hostnameMatches := hostnameRe.FindAllStringSubmatch(configData, -1)
cpusMatches := cpusRe.FindAllStringSubmatch(configData, -1)
Expect(len(hostnameMatches)).ToNot(Equal(0), "Failed to extract hostname information")
Expect(len(cpusMatches)).ToNot(Equal(0), "Failed to extract cpus information")

By("Comparing CPU sets of guaranteed pod and runc")
uniqueCombinations := make(map[string]struct{})
zippedMatches := make([]map[string]string, 0)
for i := 0; i < len(hostnameMatches) && i < len(cpusMatches); i++ {
combination := fmt.Sprintf("%s-%s", hostnameMatches[i][1], cpusMatches[i][1])
if _, exists := uniqueCombinations[combination]; !exists {
uniqueCombinations[combination] = struct{}{}
zippedMatches = append(zippedMatches, map[string]string{
"hostname": hostnameMatches[i][1],
"cpus": cpusMatches[i][1],
})
}
}
guaranteedPodCpus, err := cpuset.Parse(zippedMatches[0]["cpus"])
Expect(err).ToNot(HaveOccurred(), "Failed to parse CPU set for guaranteed pod")
runcCpus, err := cpuset.Parse(zippedMatches[1]["cpus"])
Expect(err).ToNot(HaveOccurred(), "Failed to parse CPU set for runc")

By("Checking for overlap between guaranteed pod cpus and runc cpus")
overlap := guaranteedPodCpus.Intersection(runcCpus).List()
Expect(overlap).To(BeEmpty(), "Overlap found between guaranteedPod cpus (%s) and runtime Cpus (%s), not expected behaviour", guaranteedPodCpus, runcCpus)
})
})

})

func makePod(ctx context.Context, workerRTNode *corev1.Node, guaranteed bool) *corev1.Pod {
testPod := pods.GetTestPod()
testPod.Namespace = testutils.NamespaceTesting
testPod.Spec.NodeSelector = map[string]string{testutils.LabelHostname: workerRTNode.Name}
if guaranteed {
testPod.Spec.Containers[0].Resources = corev1.ResourceRequirements{
Limits: corev1.ResourceList{
corev1.ResourceCPU: resource.MustParse("2"),
corev1.ResourceMemory: resource.MustParse("200Mi"),
},
}
}
profile, _ := profiles.GetByNodeLabels(testutils.NodeSelectorLabels)
runtimeClass := components.GetComponentName(profile.Name, components.ComponentNamePrefix)
testPod.Spec.RuntimeClassName = &runtimeClass
return testPod
}

func checkForWorkloadPartitioning(ctx context.Context) bool {
// Look for the correct Workload Partition annotation in
// a crio configuration file on the target node
Expand Down

0 comments on commit 083325f

Please sign in to comment.