Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.17] OCPBUGS-45086: Re-disable metrics server #2579

Open
wants to merge 1 commit into
base: release-4.17
Choose a base branch
from

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #2516

/assign kyrtapz

/cherrypick release-4.16

The metrics server was incorectly enabled in acd67b4
Revert this behavior by specifying the metrics port in the options.

Signed-off-by: Patryk Diak <[email protected]>
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-42189 has been cloned as Jira Issue OCPBUGS-45086. Will retitle bug to link to clone.
/retitle [release-4.17] OCPBUGS-45086: Re-disable metrics server

In response to this:

This is an automated cherry-pick of #2516

/assign kyrtapz

/cherrypick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.17] OCPBUGS-42189: Re-disable metrics server [release-4.17] OCPBUGS-45086: Re-disable metrics server Nov 26, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 26, 2024
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-45086, which is invalid:

  • expected dependent Jira Issue OCPBUGS-42189 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #2516

/assign kyrtapz

/cherrypick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from jcaamano and trozet November 26, 2024 20:18
Copy link
Contributor

openshift-ci bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign trozet for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Nov 27, 2024

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-ovn f203a2f link false /test e2e-openstack-ovn
ci/prow/e2e-aws-hypershift-ovn-kubevirt f203a2f link false /test e2e-aws-hypershift-ovn-kubevirt
ci/prow/4.17-upgrade-from-stable-4.16-e2e-gcp-ovn-upgrade f203a2f link false /test 4.17-upgrade-from-stable-4.16-e2e-gcp-ovn-upgrade
ci/prow/e2e-gcp-ovn f203a2f link true /test e2e-gcp-ovn
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 f203a2f link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/security f203a2f link false /test security
ci/prow/e2e-network-mtu-migration-ovn-ipv4 f203a2f link false /test e2e-network-mtu-migration-ovn-ipv4

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kyrtapz
Copy link
Contributor

kyrtapz commented Jan 21, 2025

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@kyrtapz: This pull request references Jira Issue OCPBUGS-45086, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kyrtapz
Copy link
Contributor

kyrtapz commented Jan 21, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 21, 2025
@openshift-ci-robot
Copy link
Contributor

@kyrtapz: This pull request references Jira Issue OCPBUGS-45086, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.z) matches configured target version for branch (4.17.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-42189 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-42189 targets the "4.18.0" version, which is one of the valid target versions: 4.18.0
  • bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kyrtapz
Copy link
Contributor

kyrtapz commented Jan 21, 2025

@pperiyasamy ptal

@qiowang721
Copy link

/label qe-approved
pre-merge testing passed.
Version:

build openshift/cluster-network-operator#2579

Steps:

1. create compact OCP cluster
% oc get node
NAME                                        STATUS   ROLES                         AGE    VERSION
ip-10-0-19-209.us-east-2.compute.internal   Ready    control-plane,master,worker   176m   v1.30.7
ip-10-0-41-129.us-east-2.compute.internal   Ready    control-plane,master,worker   176m   v1.30.7
ip-10-0-81-142.us-east-2.compute.internal   Ready    control-plane,master,worker   176m   v1.30.7

2. create hostnetwork pod, listening on port 8080
% oc get pod -owide -n ns1
NAME        READY   STATUS    RESTARTS   AGE   IP            NODE                                        NOMINATED NODE   READINESS GATES
hello-pod   1/1     Running   0          14s   10.0.41.129   ip-10-0-41-129.us-east-2.compute.internal              

3. check on the node which hostnetowrk pod lands on, the pod is listening on port 8080
% oc debug node/ip-10-0-41-129.us-east-2.compute.internal -- netstat -tulpen | grep 8080
Starting pod/ip-10-0-41-129us-east-2computeinternal-debug-bf5mg ...
To use host binaries, run `chroot /host`
Removing debug pod ...
tcp6       0      0 :::8080                 :::*                    LISTEN      1000700000 1501829    102012/hello_opensh

4. check the network-operator pod is not in CrashLoopBackOff state, and there is no error message about metrics server
% oc get pod -n openshift-network-operator -l name=network-operator                                    
NAME                                READY   STATUS    RESTARTS       AGE
network-operator-6ccdb45bdf-nbkz4   1/1     Running   1 (177m ago)   3h1m
% oc describe pod/network-operator-6ccdb45bdf-nbkz4 -n openshift-network-operator | grep "metrics server"
% oc describe pod/network-operator-6ccdb45bdf-nbkz4 -n openshift-network-operator | grep "address already in use"
%

5. check cluster-network-operator is not DEGRADED
% oc get co | grep network
network                                    4.17.0-0.ci.test-2025-01-22-023907-ci-ln-hwx4i0t-latest   True        False         False      178m 

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jan 22, 2025
@openshift-ci-robot openshift-ci-robot added jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. and removed jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jan 22, 2025
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-45086, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

This is an automated cherry-pick of #2516

/assign kyrtapz

/cherrypick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants