Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-24214: Add ownership annotations #2120

Merged
merged 3 commits into from
Feb 12, 2024
Merged

OCPBUGS-24214: Add ownership annotations #2120

merged 3 commits into from
Feb 12, 2024

Conversation

vrutkovs
Copy link
Member

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 21, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 21, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@vrutkovs vrutkovs force-pushed the annotate-owners branch 2 times, most recently from bf4ca66 to c02ad40 Compare November 21, 2023 14:37
@vrutkovs
Copy link
Member Author

/test e2e-gcp-ovn

@vrutkovs
Copy link
Member Author

/test e2e-gcp-ovn

@vrutkovs
Copy link
Member Author

/test e2e-gcp-ovn

@vrutkovs
Copy link
Member Author

/test e2e-gcp-ovn

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 28, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 28, 2023
@vrutkovs
Copy link
Member Author

/test e2e-gcp-ovn

@vrutkovs
Copy link
Member Author

/test e2e-gcp-ovn

@deads2k
Copy link
Contributor

deads2k commented Nov 28, 2023

After real bump, this lgtm.

@vrutkovs vrutkovs marked this pull request as ready for review November 29, 2023 08:33
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 29, 2023
@deads2k
Copy link
Contributor

deads2k commented Nov 29, 2023

/lgtm

1 similar comment
@JacobTanenbaum
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 29, 2023
@kyrtapz
Copy link
Contributor

kyrtapz commented Feb 8, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 1c7955f and 2 for PR HEAD c7d1f9e in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD acc819e and 1 for PR HEAD c7d1f9e in total

@kyrtapz
Copy link
Contributor

kyrtapz commented Feb 8, 2024

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2024
kyrtapz
kyrtapz reviewed Feb 8, 2024
View reviewed changes
bindata/network/ovn-kubernetes/managed/007-certificate.yaml Outdated
@@ -8,6 +8,8 @@ metadata:
annotations:
network.operator.openshift.io/cluster-name: {{.ManagementClusterName}}
network.operator.openshift.io/copy-from: "default/openshift-ovn-kubernetes/ovn-cert"
annotations:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
annotations:
openshift.io/owning-component: "Networking / cluster-network-operator"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, bad rebase. Fixed

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2024
@kyrtapz
Copy link
Contributor

kyrtapz commented Feb 9, 2024

/test e2e-hypershift-ovn

3 similar comments
@kyrtapz
Copy link
Contributor

kyrtapz commented Feb 9, 2024

/test e2e-hypershift-ovn

@kyrtapz
Copy link
Contributor

kyrtapz commented Feb 12, 2024

/test e2e-hypershift-ovn

@kyrtapz
Copy link
Contributor

kyrtapz commented Feb 12, 2024

/test e2e-hypershift-ovn

@kyrtapz
Copy link
Contributor

kyrtapz commented Feb 12, 2024

/lgtm
/hold cancel

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Feb 12, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, JacobTanenbaum, kyrtapz, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JacobTanenbaum,kyrtapz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 1a0de92 and 2 for PR HEAD 98acf32 in total

@kyrtapz
Copy link
Contributor

kyrtapz commented Feb 12, 2024

CI was broken
/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 138bdf1 into openshift:master Feb 12, 2024
38 of 42 checks passed
@openshift-ci-robot
Copy link
Contributor

@vrutkovs: Jira Issue OCPBUGS-24214: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-24214 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 12, 2024

@vrutkovs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-ovn-dualstack 98acf32 link false /test e2e-vsphere-ovn-dualstack
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 98acf32 link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/security 98acf32 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-cherrypick-robot
Copy link

@vrutkovs: new pull request created: #2271

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 12, 2024
Closed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-network-operator-container-v4.16.0-202402130109.p0.g138bdf1.assembly.stream.el9 for distgit cluster-network-operator.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2024-02-17-013806

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyrtapz kyrtapz kyrtapz left review comments

@danwinship danwinship Awaiting requested review from danwinship

@JacobTanenbaum JacobTanenbaum Awaiting requested review from JacobTanenbaum

@anuragthehatter anuragthehatter Awaiting requested review from anuragthehatter

Assignees

@deads2k deads2k

@JacobTanenbaum JacobTanenbaum

@kyrtapz kyrtapz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@vrutkovs @deads2k @JacobTanenbaum @openshift-ci-robot @openshift-cherrypick-robot @tssurya @kyrtapz @openshift-bot @openshift-merge-robot