-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NE-1869: Bump Gateway API to v1.0.0 and OSSM to v2.6 #1163
NE-1869: Bump Gateway API to v1.0.0 and OSSM to v2.6 #1163
Conversation
Separe commit for vendor files. go get sigs.k8s.io/[email protected] go mod tidy go mod vendor
@candita: This pull request references NE-1716 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@candita: This pull request references NE-1716 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@candita: This pull request references NE-1716 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/test e2e-aws-gatewayapi |
/test all |
8a90268
to
647d255
Compare
/assign @rfredette |
Failures were caused by etcd. |
Update CRDS to version 1.0.0: - pkg/manifests/assets/gateway-api/gateway.networking.k8s.io_gatewayclasses.yaml - pkg/manifests/assets/gateway-api/gateway.networking.k8s.io_gateways.yaml - pkg/manifests/assets/gateway-api/gateway.networking.k8s.io_httproutes.yaml - pkg/manifests/assets/gateway-api/gateway.networking.k8s.io_referencegrants.yaml Update imports to v1: - pkg/operator/client/client.go - pkg/operator/controller/gateway-service-dns/controller.go - pkg/operator/controller/gateway-service-dns/controller_test.go - pkg/operator/controller/gatewayclass/controller.go: also update the predicate that excludes Istio objects. - pkg/operator/controller/gatewayclass/servicemeshcontrolplane.go: also update the OSSM version from 2.5 to 2.6. - pkg/operator/controller/names.go - test/e2e/gateway_api_test.go - test/e2e/util_gatewayapi_test.go
647d255
to
92649ef
Compare
--- FAIL: TestAll/parallel/TestAWSLBTypeChange (279.13s) due to one or more of these errors: === NAME TestAll/parallel/TestAWSLBTypeChange === NAME TestAll/parallel/TestAWSLBTypeChange /test e2e-aws-operator-techpreview |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rfredette The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
hypershift failures don't seem related.
/test e2e-hypershift |
@candita: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
[ART PR BUILD NOTIFIER] Distgit: ose-cluster-ingress-operator |
/jira refresh |
Update CRDS to version 1.0.0:
- pkg/manifests/assets/gateway-api/gateway.networking.k8s.io_gatewayclasses.yaml
- pkg/manifests/assets/gateway-api/gateway.networking.k8s.io_gateways.yaml
- pkg/manifests/assets/gateway-api/gateway.networking.k8s.io_httproutes.yaml
- pkg/manifests/assets/gateway-api/gateway.networking.k8s.io_referencegrants.yaml
Update imports to v1:
- pkg/operator/client/client.go
- pkg/operator/controller/gateway-service-dns/controller.go
- pkg/operator/controller/gateway-service-dns/controller_test.go
- pkg/operator/controller/gatewayclass/controller.go: also update the predicate that excludes Istio objects.
- pkg/operator/controller/gatewayclass/servicemeshcontrolplane.go: also update the OSSM version from 2.5 to 2.6.
- pkg/operator/controller/names.go
- test/e2e/gateway_api_test.go
- test/e2e/util_gatewayapi_test.go
Update vendored code