Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NE-1869: Bump Gateway API to v1.0.0 and OSSM to v2.6 #1163

Merged

Conversation

candita
Copy link
Contributor

@candita candita commented Oct 25, 2024

Update CRDS to version 1.0.0:
- pkg/manifests/assets/gateway-api/gateway.networking.k8s.io_gatewayclasses.yaml
- pkg/manifests/assets/gateway-api/gateway.networking.k8s.io_gateways.yaml
- pkg/manifests/assets/gateway-api/gateway.networking.k8s.io_httproutes.yaml
- pkg/manifests/assets/gateway-api/gateway.networking.k8s.io_referencegrants.yaml

Update imports to v1:
- pkg/operator/client/client.go
- pkg/operator/controller/gateway-service-dns/controller.go
- pkg/operator/controller/gateway-service-dns/controller_test.go
- pkg/operator/controller/gatewayclass/controller.go: also update the predicate that excludes Istio objects.
- pkg/operator/controller/gatewayclass/servicemeshcontrolplane.go: also update the OSSM version from 2.5 to 2.6.
- pkg/operator/controller/names.go
- test/e2e/gateway_api_test.go
- test/e2e/util_gatewayapi_test.go

Update vendored code

     go get sigs.k8s.io/[email protected]
     go mod tidy
     go mod vendor

Separe commit for vendor files.

 go get sigs.k8s.io/[email protected]
 go mod tidy
 go mod vendor
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 25, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 25, 2024

@candita: This pull request references NE-1716 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set.

In response to this:

Update CRDS to version 1.0.0:

  • pkg/manifests/assets/gateway-api/gateway.networking.k8s.io_gatewayclasses.yaml
  • pkg/manifests/assets/gateway-api/gateway.networking.k8s.io_gateways.yaml
  • pkg/manifests/assets/gateway-api/gateway.networking.k8s.io_httproutes.yaml
  • pkg/manifests/assets/gateway-api/gateway.networking.k8s.io_referencegrants.yaml

Update imports to v1:

  • pkg/operator/client/client.go
  • pkg/operator/controller/gateway-service-dns/controller.go
  • pkg/operator/controller/gateway-service-dns/controller_test.go
  • pkg/operator/controller/gatewayclass/controller.go:
    also update the predicate that excludes Istio objects.
  • pkg/operator/controller/gatewayclass/servicemeshcontrolplane.go:
    also update the OSSM version from 2.5 to 2.6.
  • pkg/operator/controller/names.go
  • test/e2e/gateway_api_test.go
  • test/e2e/util_gatewayapi_test.go

Update vendored code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 25, 2024

@candita: This pull request references NE-1716 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set.

In response to this:

Update CRDS to version 1.0.0:

  • pkg/manifests/assets/gateway-api/gateway.networking.k8s.io_gatewayclasses.yaml
  • pkg/manifests/assets/gateway-api/gateway.networking.k8s.io_gateways.yaml
  • pkg/manifests/assets/gateway-api/gateway.networking.k8s.io_httproutes.yaml
  • pkg/manifests/assets/gateway-api/gateway.networking.k8s.io_referencegrants.yaml

Update imports to v1:

  • pkg/operator/client/client.go
  • pkg/operator/controller/gateway-service-dns/controller.go
  • pkg/operator/controller/gateway-service-dns/controller_test.go
  • pkg/operator/controller/gatewayclass/controller.go:
    also update the predicate that excludes Istio objects.
  • pkg/operator/controller/gatewayclass/servicemeshcontrolplane.go:
    also update the OSSM version from 2.5 to 2.6.
  • pkg/operator/controller/names.go
  • test/e2e/gateway_api_test.go
  • test/e2e/util_gatewayapi_test.go

Update vendored code
go get sigs.k8s.io/[email protected]
go mod tidy
go mod vendor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 25, 2024

@candita: This pull request references NE-1716 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set.

In response to this:

Update CRDS to version 1.0.0:

  • pkg/manifests/assets/gateway-api/gateway.networking.k8s.io_gatewayclasses.yaml
  • pkg/manifests/assets/gateway-api/gateway.networking.k8s.io_gateways.yaml
  • pkg/manifests/assets/gateway-api/gateway.networking.k8s.io_httproutes.yaml
  • pkg/manifests/assets/gateway-api/gateway.networking.k8s.io_referencegrants.yaml

Update imports to v1:

  • pkg/operator/client/client.go
  • pkg/operator/controller/gateway-service-dns/controller.go
  • pkg/operator/controller/gateway-service-dns/controller_test.go
  • pkg/operator/controller/gatewayclass/controller.go: also update the predicate that excludes Istio objects.
  • pkg/operator/controller/gatewayclass/servicemeshcontrolplane.go: also update the OSSM version from 2.5 to 2.6.
  • pkg/operator/controller/names.go
  • test/e2e/gateway_api_test.go
  • test/e2e/util_gatewayapi_test.go

Update vendored code

    go get sigs.k8s.io/[email protected]
    go mod tidy
    go mod vendor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@candita candita changed the title NE-1716: Bump Gateway API to v1.0.0 and OSSM to v2.6 WIP: NE-1716: Bump Gateway API to v1.0.0 and OSSM to v2.6 Oct 25, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 25, 2024
@candita candita marked this pull request as draft October 25, 2024 23:48
@candita
Copy link
Contributor Author

candita commented Oct 25, 2024

/test e2e-aws-gatewayapi

@candita
Copy link
Contributor Author

candita commented Oct 28, 2024

/test all

@candita candita force-pushed the NE-1716-Test-GWAPI1.0.0-OSSM2.6 branch from 8a90268 to 647d255 Compare October 30, 2024 14:45
@candita candita marked this pull request as ready for review October 30, 2024 14:45
@openshift-ci openshift-ci bot requested a review from frobware October 30, 2024 14:47
@candita
Copy link
Contributor Author

candita commented Oct 30, 2024

/assign @rfredette

@candita
Copy link
Contributor Author

candita commented Oct 30, 2024

Failures were caused by etcd.
/test e2e-azure-ovn

Update CRDS to version 1.0.0:
- pkg/manifests/assets/gateway-api/gateway.networking.k8s.io_gatewayclasses.yaml
- pkg/manifests/assets/gateway-api/gateway.networking.k8s.io_gateways.yaml
- pkg/manifests/assets/gateway-api/gateway.networking.k8s.io_httproutes.yaml
- pkg/manifests/assets/gateway-api/gateway.networking.k8s.io_referencegrants.yaml

Update imports to v1:
- pkg/operator/client/client.go
- pkg/operator/controller/gateway-service-dns/controller.go
- pkg/operator/controller/gateway-service-dns/controller_test.go
- pkg/operator/controller/gatewayclass/controller.go:
  	also update the predicate that excludes Istio objects.
- pkg/operator/controller/gatewayclass/servicemeshcontrolplane.go:
  	also update the OSSM version from 2.5 to 2.6.
- pkg/operator/controller/names.go
- test/e2e/gateway_api_test.go
- test/e2e/util_gatewayapi_test.go
@candita candita force-pushed the NE-1716-Test-GWAPI1.0.0-OSSM2.6 branch from 647d255 to 92649ef Compare October 30, 2024 19:07
@candita candita changed the title WIP: NE-1716: Bump Gateway API to v1.0.0 and OSSM to v2.6 NE-1716: Bump Gateway API to v1.0.0 and OSSM to v2.6 Oct 30, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 30, 2024
@candita
Copy link
Contributor Author

candita commented Oct 31, 2024

--- FAIL: TestAll/parallel/TestAWSLBTypeChange (279.13s) due to one or more of these errors:

=== NAME TestAll/parallel/TestAWSLBTypeChange
operator_test.go:1343: load balancer has no "service.beta.kubernetes.io/aws-load-balancer-type" annotation: map[service.beta.kubernetes.io/aws-load-balancer-healthcheck-healthy-threshold:2 service.beta.kubernetes.io/aws-load-balancer-healthcheck-interval:5 service.beta.kubernetes.io/aws-load-balancer-healthcheck-timeout:4 service.beta.kubernetes.io/aws-load-balancer-healthcheck-unhealthy-threshold:2 service.beta.kubernetes.io/aws-load-balancer-proxy-protocol:* traffic-policy.network.alpha.openshift.io/local-with-fallback:]

=== NAME TestAll/parallel/TestAWSLBTypeChange
operator_test.go:1355: WARNING: cloud resources may have been leaked! failed to delete ingresscontroller awslb: timed out waiting for ingresscontroller to be deleted: timed out waiting for the condition

/test e2e-aws-operator-techpreview

@rfredette
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2024
Copy link
Contributor

openshift-ci bot commented Nov 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfredette

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 1ee3995 and 2 for PR HEAD 92649ef in total

@candita
Copy link
Contributor Author

candita commented Nov 1, 2024

hypershift failures don't seem related.
=== FAIL: TestNodePool/HostedCluster0/Main (0.04s)

eventually.go:100: Failed to get *v1beta1.NodePool: client rate limiter Wait returned an error: context deadline exceeded
nodepool_test.go:337: Failed to wait for NodePool e2e-clusters-h9xg8/example-wtzt6-test-inplaceupgrade to have correct status in 10m0s: context deadline exceeded
eventually.go:220: observed *v1beta1.NodePool e2e-clusters-h9xg8/example-wtzt6-test-inplaceupgrade invalid at RV 107956 after 10m0s: incorrect condition: wanted ReachedIgnitionEndpoint=True, got ReachedIgnitionEndpoint=False: ignitionNotReached
--- FAIL: TestNodePool/HostedCluster0/Main/TestNodePoolInPlaceUpgrade (1502.02s)

/test e2e-hypershift

Copy link
Contributor

openshift-ci bot commented Nov 2, 2024

@candita: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit aa8860a into openshift:master Nov 2, 2024
17 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-ingress-operator
This PR has been included in build ose-cluster-ingress-operator-container-v4.18.0-202411020307.p0.gaa8860a.assembly.stream.el9.
All builds following this will include this PR.

@candita candita changed the title NE-1716: Bump Gateway API to v1.0.0 and OSSM to v2.6 NE-1869: Bump Gateway API to v1.0.0 and OSSM to v2.6 Nov 4, 2024
@candita
Copy link
Contributor Author

candita commented Nov 4, 2024

/jira refresh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants