CORS-2317: Add Ingress LB IPs to Infra CR and set DNS unmanaged when BYO DNS is enabled #1016
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@sadasu: This pull request references CORS-2317 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@sadasu: This pull request references CORS-2317 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@Miciah could PTAL? |
sadasu
force-pushed
the
custom-dns
branch
3 times, most recently
from
28996d4 to
d17eac6
Compare
|
/retest-required |
sadasu
changed the title
|
/retest-required |
|
/assign |
|
/assign @gcs278 |
There was a problem hiding this comment.
Would you mind combining the first three commits?
- "Updating openshift/api to bring in changes for BYO DNS for GCP"
- "Update vendoring as result of openshift/api and k8s.io version bump"
- "Update IngressController CRD with the openshift/api version bump"
The goal here is that each individual commit should pass make test verify. I do appreciate that you separated the vendor bump from the implementation commits!
|
/retest-required |
|
/lgtm |
|
/test e2e-aws-ovn-single-node |
Bumping the versions for both openshift/api and its dependency k8s.io/* to bring in the latest Infrastructure CR updates. Also, updatng vendoring and IngressController CRD due to the version bump.
|
/retest-required |
| k8s.io/apiextensions-apiserver v0.28.3 | ||
| k8s.io/apimachinery v0.28.3 | ||
| k8s.io/apiserver v0.28.3 | ||
| k8s.io/api v0.29.0 |
There was a problem hiding this comment.
Could we go ahead and take 0.29.1 for these K8S packages?
There was a problem hiding this comment.
This PR only bumps the k8s.io/* packages to v0.29.0 because the openshift/api bump requires doing so. I expect we'll bump to k8s.io/api v0.29.1 or later in a future PR (for example, for a controller-runtime bump or another openshift/api bump).
There was a problem hiding this comment.
That's fine if we want do it later. It was more of a "why not use the latest if we are bumping now" sort of thing, but we can just plan on doing it later.
openshift-ci
bot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Thanks for the quick responses @sadasu |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest-required |
|
@sadasu: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-cluster-ingress-operator-container-v4.16.0-202402010541.p0.gd31546e.assembly.stream for distgit ose-cluster-ingress-operator. |
ClusterHostedDNS is enabledBased on enhancement: openshift/enhancements#1468