Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-14914: Add e2e tests for tunnel and server timeouts #1013

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alebedev87
Copy link
Contributor

@alebedev87 alebedev87 commented Jan 8, 2024

This PR adds two tests to the e2e suite. They verify the behavior of the server and tunnel router timeouts. The following behaviors are supposed to be covered :

A new test command is added to cluster-ingress-operator: serve-ws-test-server. It aims at imitating a WebSocket server similar to the other server commands: serve-grpc-test-server, serve-http2-test-server.

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jan 8, 2024
@openshift-ci-robot
Copy link
Contributor

@alebedev87: This pull request references Jira Issue OCPBUGS-14914, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @ShudiLi

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR adds two tests to the e2e suite. They test the 2 router timeouts which were modified by openshift/router#536: tunnel and server.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jan 8, 2024
@openshift-ci openshift-ci bot requested review from ShudiLi, candita and knobunc January 8, 2024 15:05
Copy link
Contributor

openshift-ci bot commented Jan 8, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from alebedev87. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alebedev87 alebedev87 force-pushed the e2e-timeout-backend branch from 287f53b to 4f889c2 Compare January 8, 2024 16:29
@openshift-ci-robot
Copy link
Contributor

@alebedev87: An error was encountered querying GitHub for users with public email ([email protected]) for bug OCPBUGS-14914 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message. Post "http://ghproxy/graphql": dial tcp 172.30.229.2:80: connect: connection refused

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

In response to this:

This PR adds two tests to the e2e suite. They test two router timeouts which were modified by openshift/router#536: tunnel and server.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@alebedev87 alebedev87 force-pushed the e2e-timeout-backend branch from 4f889c2 to a9248aa Compare January 8, 2024 20:45
@alebedev87 alebedev87 changed the title OCPBUGS-14914: e2e - test tunnel and server timeouts [WIP] OCPBUGS-14914: e2e - test tunnel and server timeouts Jan 10, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 10, 2024
@alebedev87 alebedev87 force-pushed the e2e-timeout-backend branch 2 times, most recently from ca9c7c6 to bab273b Compare January 11, 2024 20:55
@alebedev87 alebedev87 changed the title [WIP] OCPBUGS-14914: e2e - test tunnel and server timeouts OCPBUGS-14914: e2e - test tunnel and server timeouts Jan 16, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 16, 2024
@openshift-ci-robot
Copy link
Contributor

@alebedev87: This pull request references Jira Issue OCPBUGS-14914, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @ShudiLi

In response to this:

This PR adds two tests to the e2e suite. They test two router timeouts: server and tunnel. They are supposed to cover the following behaviors:

A new test command is added to cluster-ingress-operator: serve-ws-test-server. It aims at imitating a WebSocket server similar to the other server commands: serve-grpc-test-server, serve-http2-test-server.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ShudiLi
Copy link
Member

ShudiLi commented Feb 1, 2024

/label qe-approved

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 1, 2024
@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Feb 1, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 6, 2024
@alebedev87
Copy link
Contributor Author

alebedev87 commented Apr 10, 2024

/hold

Until openshift/router#536 is merged.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 10, 2024
@Miciah
Copy link
Contributor

Miciah commented Apr 24, 2024

/assign

@candita
Copy link
Contributor

candita commented Apr 24, 2024

/assign

@candita
Copy link
Contributor

candita commented Apr 24, 2024

E2E for TestTunnelTimeout never finds the host. May need to wait longer.

NAME TestAll/parallel/TestTunnelTimeout
operator_test.go:3344: lookup slow-wssrv-openshift-ingress.test-tunnel-timeout.ci-op-c3sylg6j-43abb.origin-ci-int-aws.dev.rhcloud.com on 172.30.0.10:53: no such host

@alebedev87
Copy link
Contributor Author

Reanimating the PR:

  • rebased from master
  • replaced context.TODO() with context.Background()
  • replaced defer with testing.T.Cleanup()
  • replaced wait.PollImmediate() with wait.PollUntilContextTimeout()

@alebedev87 alebedev87 changed the title OCPBUGS-14914: e2e - test tunnel and server timeouts OCPBUGS-14914: Add e2e tests for tunnel and server timeouts Jul 2, 2024
@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 1, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 1, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 30, 2024
@alebedev87
Copy link
Contributor Author

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 30, 2024
@alebedev87
Copy link
Contributor Author

/testwith openshift/cluster-ingress-operator/master/e2e-aws-operator openshift/router#536

@Miciah Miciah added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Nov 13, 2024
- Added a new command to run a websocket server that delays responses.
- Implemented e2e scenarios to test the server and tunnel timeout tuning options.
@alebedev87
Copy link
Contributor Author

Rebased from master to fix the merge conflict.

Copy link
Contributor

openshift-ci bot commented Nov 25, 2024

@alebedev87: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-operator c3f656e link true /test e2e-gcp-operator
ci/prow/e2e-aws-operator-techpreview c3f656e link false /test e2e-aws-operator-techpreview
ci/prow/e2e-aws-operator c3f656e link true /test e2e-aws-operator
ci/prow/e2e-aws-ovn-techpreview c3f656e link false /test e2e-aws-ovn-techpreview
ci/prow/e2e-azure-operator c3f656e link true /test e2e-azure-operator
ci/prow/e2e-hypershift c3f656e link true /test e2e-hypershift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. priority/backlog Higher priority than priority/awaiting-more-evidence. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants