Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add manifests in the resulting docker image #80

Merged
merged 2 commits into from
Aug 9, 2022
Merged

Add manifests in the resulting docker image #80

merged 2 commits into from
Aug 9, 2022

Conversation

Fedosin
Copy link
Contributor

@Fedosin Fedosin commented Aug 8, 2022

Currently we don't copy manifests in the image and therefore CVO can't deploy it.

@Fedosin
Add manifests in the resulting docker image
3456b8f 
Currently we don't copy manifests in the image and therefore CVO
can't deploy it in CI.
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 8, 2022
@JoelSpeed
Copy link
Contributor

This is failing because we don't have the version set in the cluster operator. Let's make sure we fix that before merging this
/hold

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 8, 2022
@Fedosin Fedosin force-pushed the manifests_dockerfile branch from 599b5ae to 67046ad Compare August 8, 2022 17:12
JoelSpeed
JoelSpeed reviewed Aug 8, 2022
View reviewed changes
cmd/control-plane-machine-set-operator/main.go Outdated
releaseVersion := os.Getenv(releaseVersionEnvVariableName)
if len(releaseVersion) == 0 {
releaseVersion = unknownVersionValue
klog.Infof("%s environment variable is missing, defaulting to %q", releaseVersionEnvVariableName, unknownVersionValue)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please pass in a logr.Logger and log using that to be consistent with the rest of this operator. You can pass through the setupLog we init on line 57

@JoelSpeed
Copy link
Contributor

/hold cancel, I think other than the nit this should be good to go

@JoelSpeed JoelSpeed mentioned this pull request Aug 8, 2022
Merged
@Fedosin Fedosin force-pushed the manifests_dockerfile branch from 67046ad to 1fc8102 Compare August 8, 2022 20:34
@Fedosin
Report cluster operator version
584913f 
This commit adds cluster operator version to the clusteroperator
resource.
@Fedosin Fedosin force-pushed the manifests_dockerfile branch from 1fc8102 to 584913f Compare August 8, 2022 21:09
@JoelSpeed
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2022
@Fedosin
Copy link
Contributor Author

Fedosin commented Aug 9, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 9, 2022
@Fedosin
Copy link
Contributor Author

Fedosin commented Aug 9, 2022

/test e2e-aws-serial

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD 4260e66 and 8 for PR HEAD 584913f in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 9, 2022

@Fedosin: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-disruptive 584913f link false /test e2e-aws-disruptive

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit f839f86 into openshift:main Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed JoelSpeed left review comments

@alexander-demicev alexander-demicev Awaiting requested review from alexander-demicev

@damdo damdo Awaiting requested review from damdo

Assignees

@JoelSpeed JoelSpeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Fedosin @JoelSpeed @openshift-ci-robot @openshift-merge-robot