Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPCLOUD-2010: Re-vendor api to support external platform #306

Merged
merged 1 commit into from
Jun 14, 2023
Merged

OCPCLOUD-2010: Re-vendor api to support external platform #306

merged 1 commit into from
Jun 14, 2023

Conversation

adriengentil
Copy link
Contributor

@adriengentil adriengentil commented May 17, 2023 •
edited
Loading

Re-vendor openshift/api in order to support the external platform.

API PR: openshift/api#1434

@openshift-ci openshift-ci bot requested review from elmiko and JoelSpeed May 17, 2023 08:35
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 17, 2023
@JoelSpeed
Copy link
Contributor

@adriengentil Before/if this ever gets merged somewhere, please remove the github handles from the commit message. Having github handles in commit messages is a nightmare for anyone who is tagged, any time someone forks the repo or pushes this commit in some way, GitHub will notify you

@adriengentil adriengentil force-pushed the revendor-external-platform branch from 726a79d to da1713e Compare May 17, 2023 08:39
@adriengentil
Copy link
Contributor Author

/test e2e-aws-ovn

@adriengentil adriengentil force-pushed the revendor-external-platform branch from da1713e to 814bc4c Compare May 17, 2023 13:43
@adriengentil adriengentil changed the title WIP: Test external platform api change WIP: OCPCLOUD-2010: Test external platform api change May 17, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 17, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 17, 2023 •
edited by openshift-ci bot
Loading

@adriengentil: This pull request references OCPCLOUD-2010 which is a valid jira issue.

In response to this:

Let CI run with api pointing to openshift/api#1434

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adriengentil
Copy link
Contributor Author

/test e2e-aws-ovn

@adriengentil adriengentil mentioned this pull request May 17, 2023
Merged
@adriengentil adriengentil changed the title WIP: OCPCLOUD-2010: Test external platform api change WIP: OCPCLOUD-2010: Re-vendor api to support external platform May 22, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 22, 2023 •
edited by openshift-ci bot
Loading

@adriengentil: This pull request references OCPCLOUD-2010 which is a valid jira issue.

In response to this:

Re-vendor openshift/api in order to support the external platform.

API PR: openshift/api#1434

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 24, 2023
@adriengentil adriengentil force-pushed the revendor-external-platform branch from 814bc4c to 19d072b Compare June 13, 2023 12:39
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 13, 2023
@adriengentil adriengentil force-pushed the revendor-external-platform branch from 68f3161 to 115ef07 Compare June 13, 2023 12:40
elmiko
elmiko reviewed Jun 13, 2023
View reviewed changes
Copy link

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this lgtm, obviously needs an update once the api change lands

@adriengentil
OCPCLOUD-2010: Re-vendor api to support external platform
e4ea2e1 
Re-vendor openshift/api in order to support the external platform.

API PR: openshift/api#1434
@adriengentil adriengentil force-pushed the revendor-external-platform branch from 115ef07 to e4ea2e1 Compare June 13, 2023 15:52
@adriengentil
Copy link
Contributor Author

adriengentil commented Jun 13, 2023 •
edited by openshift-ci bot
Loading

/retitle OCPCLOUD-2010: Re-vendor api to support external platform

@openshift-ci openshift-ci bot changed the title WIP: OCPCLOUD-2010: Re-vendor api to support external platform OCPCLOUD-2010: Re-vendor api to support external platform Jun 13, 2023
@elmiko
Copy link

elmiko commented Jun 13, 2023

/lgtm

@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 13, 2023
@JoelSpeed
Copy link
Contributor

This enables both DualStackNodeIPs and ExternalCloudProviderExternal, both of which have tested independently to prove that they are not affecting the existing payload
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriengentil, elmiko, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriengentil, elmiko, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 13, 2023

@adriengentil: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deepsm007
Copy link

/label jira/valid-bug

@openshift-ci openshift-ci bot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jun 14, 2023
@openshift-merge-robot openshift-merge-robot merged commit 10e6fbc into openshift:master Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elmiko elmiko elmiko left review comments

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@elmiko elmiko

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@adriengentil @JoelSpeed @openshift-ci-robot @elmiko @deepsm007 @openshift-merge-robot