Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-2076: Replace k8s.io/cloud-provider with openshift's version #28

Merged
merged 1 commit into from
Oct 14, 2022
Merged

OCPBUGS-2076: Replace k8s.io/cloud-provider with openshift's version #28

merged 1 commit into from
Oct 14, 2022

Conversation

lobziik
Copy link

@lobziik lobziik commented Oct 13, 2022

Service handling logic in k8s.io/cloud-provider v0.25.(0,1,2) is broken. This issue was fixed upstream, but not released yet. We are expecting that this fixes will be included into v0.25.3, but now need to replace released cloud-provider library version with the latest version from release-1.25 branch.

Xref: kubernetes/kubernetes#112793

This commit is expected to be dropped during next rebase.

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 13, 2022
@openshift-ci-robot
Copy link

@lobziik: This pull request references Jira Issue OCPBUGS-2076, which is invalid:

  • expected the bug to target the "4.12.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Service handling logic in k8s.io/cloud-provider v0.25.(0,1,2) is broken. This issue was fixed upstream, but not released yet. We are expecting that this fixes will be included into v0.25.3, but now need to replace released cloud-provider library version with the latest version from release-1.25 branch.

Xref: kubernetes/kubernetes#112793

This commit is expected to be dropped during next rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lobziik
Copy link
Author

lobziik commented Oct 13, 2022

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 13, 2022
@openshift-ci-robot
Copy link

@lobziik: This pull request references Jira Issue OCPBUGS-2076, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.0) matches configured target version for branch (4.12.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lobziik lobziik mentioned this pull request Oct 13, 2022
Merged
@lobziik
UPSTREAM: 112793: Replace k8s.io/cloud-provider with openshift's version
f033fac 
Service handling logic in k8s.io/cloud-provider v0.25.(0,1,2)
is broken. This issue was fixed upstream, but not released yet.
We are expecting that this fixes will be included into v0.25.3, but
now need to replace released `cloud-provider` library version with
the latest version from `release-1.25` branch.

Xref: kubernetes/kubernetes#112793

This commit is expected to be dropped during next rebase.
elmiko
elmiko reviewed Oct 13, 2022
View reviewed changes
Copy link

@elmiko elmiko left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

fwiw, the test failure did not look related to this change

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2022
@lobziik
Copy link
Author

lobziik commented Oct 14, 2022

/retest

@JoelSpeed
Copy link

/retest-required

@openshift-ci-robot openshift-ci-robot mentioned this pull request Oct 14, 2022
Merged
@openshift-ci
Copy link

openshift-ci bot commented Oct 14, 2022

@lobziik: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JoelSpeed
Copy link

/approve

@openshift-ci
Copy link

openshift-ci bot commented Oct 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2022
@openshift-merge-robot openshift-merge-robot merged commit bf18b2b into openshift:master Oct 14, 2022
@openshift-ci-robot
Copy link

@lobziik: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-2076 has not been moved to the MODIFIED state.

In response to this:

Service handling logic in k8s.io/cloud-provider v0.25.(0,1,2) is broken. This issue was fixed upstream, but not released yet. We are expecting that this fixes will be included into v0.25.3, but now need to replace released cloud-provider library version with the latest version from release-1.25 branch.

Xref: kubernetes/kubernetes#112793

This commit is expected to be dropped during next rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Oct 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elmiko elmiko elmiko left review comments

@sunzhaohua2 sunzhaohua2 Awaiting requested review from sunzhaohua2

@Fedosin Fedosin Awaiting requested review from Fedosin

Assignees

@elmiko elmiko

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lobziik @openshift-ci-robot @JoelSpeed @elmiko @openshift-merge-robot