Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ccoctl command to create infrastructure required for Azure workload identity #523

Merged
merged 34 commits into from
Jun 27, 2023
Merged

Implement ccoctl command to create infrastructure required for Azure workload identity #523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
66e92a2
Include azure-sdk-for-go dependencies necessary to create Azure infra…
abutcher Mar 28, 2023
9a7a09a
Vendor updates from including azure-sdk-for-go dependencies necessary…
abutcher Mar 28, 2023
f16de31
Implement ccoctl commands to create infrastructure required for Azure…
abutcher Mar 28, 2023
4443fe9
Add AzureClientWrapper.MockStorageClientBeginCreateResp to remove tes…
abutcher May 25, 2023
0636cab
s/PollerWrapper.generic/PollerWrapper.mockResp/g
abutcher May 25, 2023
2e48618
Idempotently tag resource groups and storage account with owned tag a…
abutcher May 30, 2023
fd06bcd
Remove unnecessary append in user-assigned managed identity deletion.
abutcher May 31, 2023
f040fa5
Fix resource group tag assignment.
abutcher May 31, 2023
491f706
Remove doc stub.
abutcher May 31, 2023
e95fa04
Clean up several incorrect comments.
abutcher May 31, 2023
efdc0c2
Remove unused returns from ensure(BlobContainer,StorageAccount,Resour…
abutcher Jun 1, 2023
6881ea0
Remove unnecessary default value from CreateAllOpts.
abutcher Jun 1, 2023
d63efdb
Rework ensureResourceGroup, ensureStorageAccount and ensure tag-based…
abutcher Jun 6, 2023
6488a89
Remove squirrelly blob tag comment.
abutcher Jun 6, 2023
90eb2ab
Adds TestEnsureBlobContainer and fixes a tag map usage/reference issue.
abutcher Jun 6, 2023
4b1a07e
Move ingress CredentialsRequest name to vars.
abutcher Jun 6, 2023
b6dbb02
Ensure user-assigned managed identity is correctly tagged.
abutcher Jun 8, 2023
55b6cb4
Idempotently reconcile desired identity role assignments, removing ex…
abutcher Jun 9, 2023
7ad7f0a
Correct ErrorCode for federated identity credential to NotFound.
abutcher Jun 12, 2023
70e05ac
Add tests for identity creation and role assignment.
abutcher Jun 13, 2023
b750267
Remove unused test struct field.
abutcher Jun 13, 2023
6bec494
Remove unused test variable.
abutcher Jun 13, 2023
695b862
Remove unused mockRoleDefinitionGetByIDSuccess func.
abutcher Jun 14, 2023
5eb0f0f
Remove github.com/gofrs from go mod/sum.
abutcher Jun 14, 2023
758c7b6
Remove github.com/gofrs from vendor directory.
abutcher Jun 14, 2023
62028d2
Replace github.com/gofrs with github.com/google/uuid since we were al…
abutcher Jun 14, 2023
6dc2cef
Correct --credentials-requests-dir usage in 'ccoctl azure create-all'…
abutcher Jun 15, 2023
27b3a7b
Bump armautorization to v2.
abutcher Jun 20, 2023
7286cda
Vendor changes from bumping armauthorization to v2.
abutcher Jun 20, 2023
0d96ce4
Convert armauthorization NewListPager to v2 NewListForScopePager.
abutcher Jun 20, 2023
76c7b29
remove armauthorization from go mod/sum
abutcher Jun 20, 2023
5689bf0
remove armauthorization from vendor
abutcher Jun 20, 2023
0fb9e29
Fix tests for armauthorization -> armauthorization/v2 swap.
abutcher Jun 20, 2023
7ba2acc
Remove log added for debugging role assignment removal.
abutcher Jun 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
The diff you're trying to view is too large. We only load the first 3000 changed files.
2 changes: 2 additions & 0 deletions cmd/ccoctl/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import (

"github.com/openshift/cloud-credential-operator/pkg/cmd/provisioning/alibabacloud"
"github.com/openshift/cloud-credential-operator/pkg/cmd/provisioning/aws"
"github.com/openshift/cloud-credential-operator/pkg/cmd/provisioning/azure"
"github.com/openshift/cloud-credential-operator/pkg/cmd/provisioning/gcp"
"github.com/openshift/cloud-credential-operator/pkg/cmd/provisioning/ibmcloud"
"github.com/openshift/cloud-credential-operator/pkg/cmd/provisioning/nutanix"
Expand All @@ -23,6 +24,7 @@ func main() {
rootCmd.AddCommand(ibmcloud.NewIBMCloudCmd())
rootCmd.AddCommand(alibabacloud.NewAliababaCloudCmd())
rootCmd.AddCommand(nutanix.NewNutanixCmd())
rootCmd.AddCommand(azure.NewAzureCmd())

if err := rootCmd.Execute(); err != nil {
log.Fatal(err)
Expand Down
47 changes: 26 additions & 21 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ require (
github.com/sirupsen/logrus v1.8.1
github.com/spf13/cobra v1.6.0
github.com/spf13/pflag v1.0.5
github.com/stretchr/testify v1.8.0
github.com/stretchr/testify v1.8.2
go.mongodb.org/mongo-driver v1.8.0 // indirect
golang.org/x/mod v0.6.0
golang.org/x/oauth2 v0.0.0-20220411215720-9780585627b5
Expand All @@ -53,22 +53,27 @@ require (
)

require (
github.com/Azure/azure-sdk-for-go/sdk/azcore v1.1.4
github.com/Azure/azure-sdk-for-go/sdk/azidentity v1.1.0
github.com/microsoft/kiota-authentication-azure-go v0.5.0
github.com/microsoftgraph/msgraph-sdk-go v0.44.0
github.com/Azure/azure-sdk-for-go/sdk/azcore v1.4.0
github.com/Azure/azure-sdk-for-go/sdk/azidentity v1.2.2
github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/authorization/armauthorization/v2 v2.1.1
github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/msi/armmsi v1.0.0
github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/resources/armresources v1.0.0
github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storage/armstorage v1.1.0
github.com/Azure/azure-sdk-for-go/sdk/storage/azblob v0.5.1
github.com/microsoft/kiota-authentication-azure-go v0.6.0
github.com/microsoftgraph/msgraph-sdk-go v0.59.0
)

require (
github.com/Azure/azure-sdk-for-go/sdk/internal v1.0.0 // indirect
github.com/Azure/azure-sdk-for-go/sdk/internal v1.2.0 // indirect
github.com/Azure/go-autorest v14.2.0+incompatible // indirect
github.com/Azure/go-autorest/logger v0.2.1 // indirect
github.com/Azure/go-autorest/tracing v0.6.0 // indirect
github.com/AzureAD/microsoft-authentication-library-for-go v0.5.1 // indirect
github.com/AzureAD/microsoft-authentication-library-for-go v0.9.0 // indirect
github.com/beorn7/perks v1.0.1 // indirect
github.com/blang/semver/v4 v4.0.0 // indirect
github.com/cespare/xxhash/v2 v2.1.2 // indirect
github.com/cjlapao/common-go v0.0.27 // indirect
github.com/cjlapao/common-go v0.0.39 // indirect
github.com/davecgh/go-spew v1.1.1 // indirect
github.com/emicklei/go-restful/v3 v3.9.0 // indirect
github.com/evanphx/json-patch v4.12.0+incompatible // indirect
Expand All @@ -84,8 +89,7 @@ require (
github.com/go-playground/locales v0.14.0 // indirect
github.com/go-stack/stack v1.8.0 // indirect
github.com/gogo/protobuf v1.3.2 // indirect
github.com/golang-jwt/jwt v3.2.1+incompatible // indirect
github.com/golang-jwt/jwt/v4 v4.2.0 // indirect
github.com/golang-jwt/jwt/v4 v4.5.0 // indirect
github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da // indirect
github.com/golang/protobuf v1.5.2 // indirect
github.com/google/gnostic v0.5.7-v3refs // indirect
Expand All @@ -100,30 +104,31 @@ require (
github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51 // indirect
github.com/kylelemons/godebug v1.1.0 // indirect
github.com/mailru/easyjson v0.7.6 // indirect
github.com/mattn/go-colorable v0.1.12 // indirect
github.com/mattn/go-isatty v0.0.14 // indirect
github.com/mattn/go-colorable v0.1.13 // indirect
github.com/mattn/go-isatty v0.0.16 // indirect
github.com/matttproud/golang_protobuf_extensions v1.0.2 // indirect
github.com/mgutz/ansi v0.0.0-20170206155736-9520e82c474b // indirect
github.com/microsoft/kiota-abstractions-go v0.12.0 // indirect
github.com/microsoft/kiota-http-go v0.9.0 // indirect
github.com/microsoft/kiota-serialization-json-go v0.7.2 // indirect
github.com/microsoft/kiota-serialization-text-go v0.6.0 // indirect
github.com/microsoftgraph/msgraph-sdk-go-core v0.30.0 // indirect
github.com/microsoft/kiota-abstractions-go v0.18.0 // indirect
github.com/microsoft/kiota-http-go v0.16.0 // indirect
github.com/microsoft/kiota-serialization-form-go v0.9.0 // indirect
github.com/microsoft/kiota-serialization-json-go v0.9.0 // indirect
github.com/microsoft/kiota-serialization-text-go v0.7.0 // indirect
github.com/microsoftgraph/msgraph-sdk-go-core v0.34.1 // indirect
github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect
github.com/modern-go/reflect2 v1.0.2 // indirect
github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 // indirect
github.com/oklog/ulid v1.3.1 // indirect
github.com/pkg/browser v0.0.0-20210115035449-ce105d075bb4 // indirect
github.com/pkg/browser v0.0.0-20210911075715-681adbf594b8 // indirect
github.com/pmezard/go-difflib v1.0.0 // indirect
github.com/prometheus/client_model v0.3.0 // indirect
github.com/prometheus/common v0.37.0 // indirect
github.com/prometheus/procfs v0.8.0 // indirect
github.com/robfig/cron v1.2.0 // indirect
github.com/yosida95/uritemplate/v3 v3.0.2 // indirect
go.opencensus.io v0.23.0 // indirect
go.opentelemetry.io/otel v1.10.0 // indirect
go.opentelemetry.io/otel/trace v1.10.0 // indirect
golang.org/x/crypto v0.1.0 // indirect
go.opentelemetry.io/otel v1.14.0 // indirect
go.opentelemetry.io/otel/trace v1.14.0 // indirect
golang.org/x/crypto v0.6.0 // indirect
golang.org/x/net v0.7.0 // indirect
golang.org/x/sys v0.5.0 // indirect
golang.org/x/term v0.5.0 // indirect
Expand Down
Loading