OCPBUILD-174: Always Build with -mod vendor
#415
Conversation
We no longer need to test if we are building with go modules and the `-mod vendor` mode; always build with `-mod vendor` because vendoring dependencies is an OpenShift standard practice. Signed-off-by: Adam Kaplan <[email protected]>
openshift-ci-robot
added
the
jira/valid-reference
|
@adambkaplan: This pull request references OCPBUILD-174 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
approved
|
/retest Unit tests should pass now that #412 merged. |
|
/override ci/prow/e2e-aws-ovn-builds Known issue with builds e2e test |
|
/override ci/prow/e2e-aws-ovn-builds-techpreview Known issue with builds e2e |
|
@adambkaplan: Overrode contexts on behalf of adambkaplan: ci/prow/e2e-aws-ovn-builds In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@adambkaplan: Overrode contexts on behalf of adambkaplan: ci/prow/e2e-aws-ovn-builds-techpreview In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan, prabhapa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
8 similar comments
|
/retest |
|
/label docs-approved No doc impact |
openshift-ci
bot
added
the
docs-approved
|
/label px-approved No product experience impact |
openshift-ci
bot
added
the
px-approved
|
/label qe-approved Verified through existing CI test suites. |
openshift-ci
bot
added
the
qe-approved
|
@adambkaplan: This pull request references OCPBUILD-174 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@adambkaplan: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit 6fba4cb
into
openshift:master
|
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-builder |
We no longer need to test if we are building with go modules and the
-mod vendormode; always build with-mod vendorbecause vendoring dependencies is an OpenShift standard practice.