-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump github.com/containers/buildah to v1.26.2 #304
bump github.com/containers/buildah to v1.26.2 #304
Conversation
/approve |
/retest |
1 similar comment
/retest |
@nalind
|
I would hope not, but it bears investigating. |
Tweak `hack/update-deps.sh` to call `go get -t` on the local `cmd` package and the latest buildah package, and pass `-compat=1.17` to `go mod tidy` to avoid an error. Update to the current version of buildah, which pulls in v1.40.3 of the storage library. Signed-off-by: Nalin Dahyabhai <[email protected]>
The default for buildah since 1.26.0 has been to create new user namespaces by default, and we don't need that. Doing so also causes it to not tell runc to mount the cgroup filesystem when creating a new cgroup namespace, giving commands the node's /sys/fs/cgroup instead of a new one for the container. Force use of the host (or more accurately "host", since we're already in a container) user namespace to just avoid all of this. Signed-off-by: Nalin Dahyabhai <[email protected]>
07edb4d
to
2e96947
Compare
@nalind: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/label docs-approved |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: coreydaley, nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Tweak update-deps.sh to call
go get -t
on the localcmd
package and the latest buildah package, and pass-compat=1.17
togo mod tidy
to avoid an error result.Update to the current version of buildah, which pulls in v1.40.3 of the storage library, which notably includes containers/storage#1261.
KATA-1278 is tracking this change for the
buildah
CLI tool, and since we're using it as a library, we're most likely affected by the problem it fixes. This may not be sufficient for us to avoid problems in that configuration, though. For cases where we have privileges but can't use kernel overlay, we may need to start trying to create/dev/fuse
ourselves so that ourfuse-overlayfs
startup-time checks will succeed.