Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1905095: bump github.com/containers/image #221

Merged
merged 1 commit into from
Mar 16, 2021
Merged

Bug 1905095: bump github.com/containers/image #221

merged 1 commit into from
Mar 16, 2021

Conversation

nalind
Copy link
Member

@nalind nalind commented Mar 9, 2021

Bump github.com/containers/image from v5.5.2 to v5.10.5 to pick up containers/image#1089 and containers/image#1138, this pulls in an update from github.com/containers/storage from v1.24.5 to v1.24.8.
Fixes #219.

@nalind
Bump github.com/containers/image
1c0da68 
Bump github.com/containers/image from v5.5.2 to v5.10.5, this pulls in
an update from github.com/containers/storage from v1.24.5 to v1.24.8.

Signed-off-by: Nalin Dahyabhai <[email protected]>
@nalind nalind changed the title Bump github.com/containers/image Bug 1905095: bump github.com/containers/image Mar 10, 2021
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Mar 10, 2021
@openshift-ci-robot
Copy link
Contributor

@nalind: This pull request references Bugzilla bug 1905095, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @xiuwang

In response to this:

Bug 1905095: bump github.com/containers/image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

adambkaplan
adambkaplan approved these changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, nalind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2021
@gabemontero
Copy link
Contributor

e2e-aws-build will fail until openshift/origin#25949 merges

@adambkaplan
Copy link
Contributor

/hold

Until ruby tests are cleaned up

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 11, 2021
@vrutkovs
Copy link
Member

/retest

@gabemontero
Copy link
Contributor

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 16, 2021
@openshift-merge-robot openshift-merge-robot merged commit 5a7d6ca into openshift:master Mar 16, 2021
@openshift-ci-robot
Copy link
Contributor

@nalind: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1905095 has not been moved to the MODIFIED state.

In response to this:

Bug 1905095: bump github.com/containers/image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nalind nalind deleted the bump-image branch March 16, 2021 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambkaplan adambkaplan adambkaplan approved these changes

@coreydaley coreydaley Awaiting requested review from coreydaley

@gabemontero gabemontero Awaiting requested review from gabemontero

@xiuwang xiuwang Awaiting requested review from xiuwang

Assignees

@adambkaplan adambkaplan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add latest containers/image with the „quay mirror fix“
6 participants
@nalind @openshift-ci-robot @gabemontero @adambkaplan @vrutkovs @openshift-merge-robot