Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add AWS ISO partitions to LB CRD #138

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gcampbell12
Copy link

@gcampbell12 gcampbell12 commented Nov 4, 2024

ISO partitions are missing from stsIAMRoleARN meaning that the operator cannot be used in these partitions in Manual credentials mode without manually modifying the CRD.

Partitions taken from https://github.com/aws/aws-sdk-go-v2/blob/main/internal/endpoints/awsrulesfn/partitions.json

@openshift-ci openshift-ci bot requested review from alebedev87 and gcs278 November 4, 2024 00:56
Copy link
Contributor

openshift-ci bot commented Nov 4, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign candita for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 4, 2024
Copy link
Contributor

openshift-ci bot commented Nov 4, 2024

Hi @gcampbell12. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@alebedev87
Copy link
Contributor

Similar PR about the support of different partitions: #130.

@alebedev87
Copy link
Contributor

alebedev87 commented Nov 20, 2024

So far, we didn't have a request to support ISO partitions. The full support would require different IAM policies (iso, isob) from the upstream for non-STS clusters.

Upd: actually there is an RFE for the support of ISO partition.

@candita
Copy link

candita commented Nov 27, 2024

/assign @alebedev87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants