MGMT-3026 - invoke fio from installcmd #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
danielerez
commented
Dec 17, 2020
•
danielerez
commented
- Invoke fio_perf_check agent command as part of installcmd flow.
- Handled error in inventory (handleReplyError) by looking for a specific fio exit code (FioPerfCheckCmdExitCode).
openshift-ci-robot
added
do-not-merge/work-in-progress
openshift-ci-robot
added
the
approved
danielerez
force-pushed
the
fio_check
branch
from
c1ec6e6 to
b23329e
Compare
danielerez
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
danielerez
force-pushed
the
fio_check
branch
2 times, most recently
from
774581c to
f94d6ce
Compare
filanov
reviewed
Dec 20, 2020
internal/host/fioperfcheckcmd.go
Outdated
| ) | ||
|
|
||
| const ( | ||
| FioPerfCheckCmdExitCode int64 = 126 |
There was a problem hiding this comment.
podman have 126 maybe something really big just to make sure that it doesn't conflict with any other error?
containers/podman#367
internal/host/installcmd_test.go
Outdated
| InstallationTimeout: 120, | ||
| ReleaseImage: "quay.io/openshift-release-dev/ocp-release@sha256:eab93b4591699a5a4ff50ad3517892653f04fb840127895bb3609b3cc68f98f3", | ||
| ReleaseImageMirror: "local.registry:5000/ocp@sha256:eab93b4591699a5a4ff50ad3517892653f04fb840127895bb3609b3cc68f98f3", | ||
| } | ||
|
|
||
| var _ = Describe("installcmd", func() { | ||
| var _ = FDescribe("installcmd", func() { |
rollandf
reviewed
Dec 20, 2020
| @@ -56,6 +56,7 @@ type InstructionConfig struct { | |||
| DhcpLeaseAllocatorImage string `envconfig:"DHCP_LEASE_ALLOCATOR_IMAGE" default:"quay.io/ocpmetal/assisted-installer-agent:latest"` | |||
| APIVIPConnectivityCheckImage string `envconfig:"API_VIP_CONNECTIVITY_CHECK_IMAGE" default:"quay.io/ocpmetal/assisted-installer-agent:latest"` | |||
There was a problem hiding this comment.
need to add to openshift/template.yaml
|
/retest |
- Invoke fio_perf_check agent command as part of installcmd flow. - Handled error in inventory (handleReplyError) by looking for a specific fio exit code (FioPerfCheckCmdExitCode).
filanov
reviewed
Dec 24, 2020
| @@ -240,6 +241,20 @@ func (m *Manager) populateDisksEligibility(inventoryString string) (string, erro | |||
| return string(result), nil | |||
| } | |||
|
|
|||
| func (m *Manager) HandlePrepareInstallationFailure(ctx context.Context, h *models.Host, reason string) error { | |||
There was a problem hiding this comment.
isn't it the same as HandleInstallationFailure?
filanov
approved these changes
Dec 27, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielerez, filanov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.