MGMT-13454: Group Host and boot logs to a single tarball #4975

nmagnezi · 2023-02-09T13:09:35Z

List all the issues related to this PR

What environments does this code impact?

Automation (CI, tools, etc)
Cloud
Operator Managed Deployments
None

How was this code tested?

assisted-test-infra environment
dev-scripts environment
Reviewer's test appreciated
Waiting for CI to do a full test run
Manual (Elaborate on how it was tested)
No tests needed

Checklist

Title and description added to both, commit and PR.
Relevant issues have been associated (see CONTRIBUTING guide)
This change does not require a documentation update (docstring, docs, README, etc)
Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

Are the title and description (in both PR and commit) meaningful and clear?
Is there a bug required (and linked) for this change?
Should this PR be backported?

openshift-ci-robot · 2023-02-09T13:09:38Z

openshift-ci · 2023-02-09T13:09:42Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

nmagnezi · 2023-02-09T13:09:53Z

/test ?

openshift-ci · 2023-02-09T13:10:03Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nmagnezi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [nmagnezi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2023-02-09T13:10:04Z

@nmagnezi: The following commands are available to trigger required jobs:

/test e2e-agent-compact
/test edge-assisted-operator-catalog-publish-verify
/test edge-ci-index
/test edge-e2e-ai-operator-ztp
/test edge-e2e-ai-operator-ztp-sno-day2-workers
/test edge-e2e-ai-operator-ztp-sno-day2-workers-late-binding
/test edge-e2e-metal-assisted
/test edge-e2e-metal-assisted-4-10
/test edge-e2e-metal-assisted-4-11
/test edge-e2e-metal-assisted-4-12
/test edge-e2e-metal-assisted-4-8
/test edge-e2e-metal-assisted-4-9
/test edge-e2e-metal-assisted-cnv
/test edge-e2e-metal-assisted-lvm
/test edge-e2e-metal-assisted-ocs
/test edge-e2e-metal-assisted-odf
/test edge-images
/test edge-lint
/test edge-subsystem-aws
/test edge-subsystem-kubeapi-aws
/test edge-unit-test
/test edge-verify-generated-code
/test images
/test mce-images

The following commands are available to trigger optional jobs:

/test edge-e2e-ai-operator-ztp-3masters
/test edge-e2e-ai-operator-ztp-capi
/test edge-e2e-ai-operator-ztp-compact-day2-masters
/test edge-e2e-ai-operator-ztp-compact-day2-workers
/test edge-e2e-ai-operator-ztp-converged
/test edge-e2e-ai-operator-ztp-disconnected
/test edge-e2e-ai-operator-ztp-hypershift-zero-nodes
/test edge-e2e-ai-operator-ztp-ipv4v6-3masters
/test edge-e2e-ai-operator-ztp-ipv4v6-3masters-ocp-411
/test edge-e2e-ai-operator-ztp-ipv4v6-sno
/test edge-e2e-ai-operator-ztp-ipv4v6-sno-ocp-411
/test edge-e2e-ai-operator-ztp-multiarch-3masters-ocp-411
/test edge-e2e-ai-operator-ztp-multiarch-sno-ocp-411
/test edge-e2e-ai-operator-ztp-sno-day2-masters
/test edge-e2e-ai-operator-ztp-sno-day2-workers-ignitionoverride
/test edge-e2e-metal-assisted-4-13
/test edge-e2e-metal-assisted-day2
/test edge-e2e-metal-assisted-day2-single-node
/test edge-e2e-metal-assisted-ipv4v6
/test edge-e2e-metal-assisted-ipv6
/test edge-e2e-metal-assisted-kube-api-late-binding-single-node
/test edge-e2e-metal-assisted-kube-api-late-unbinding-ipv4-single-node
/test edge-e2e-metal-assisted-kube-api-net-suite
/test edge-e2e-metal-assisted-none
/test edge-e2e-metal-assisted-onprem
/test edge-e2e-metal-assisted-single-node
/test edge-e2e-metal-assisted-static-ip-suite
/test edge-e2e-metal-assisted-tang
/test edge-e2e-metal-assisted-tpmv2
/test edge-e2e-metal-assisted-upgrade-agent
/test edge-e2e-nutanix-assisted
/test edge-e2e-nutanix-assisted-2workers
/test edge-e2e-vsphere-assisted
/test edge-e2e-vsphere-assisted-umn
/test edge-push-pr-image
/test push-pr-image

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-assisted-service-master-e2e-agent-compact
pull-ci-openshift-assisted-service-master-edge-ci-index
pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp
pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted
pull-ci-openshift-assisted-service-master-edge-images
pull-ci-openshift-assisted-service-master-edge-lint
pull-ci-openshift-assisted-service-master-edge-subsystem-aws
pull-ci-openshift-assisted-service-master-edge-subsystem-kubeapi-aws
pull-ci-openshift-assisted-service-master-edge-unit-test
pull-ci-openshift-assisted-service-master-edge-verify-generated-code
pull-ci-openshift-assisted-service-master-images
pull-ci-openshift-assisted-service-master-mce-images

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nmagnezi · 2023-02-09T13:10:19Z

/test edge-lint
/test edge-unit-test

codecov · 2023-02-09T13:36:09Z

Codecov Report

Merging #4975 (c5e83ca) into master (ef2761d) will increase coverage by 1.77%.
The diff coverage is 41.90%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4975      +/-   ##
==========================================
+ Coverage   67.53%   69.31%   +1.77%     
==========================================
  Files         204      204              
  Lines       30509    33029    +2520     
==========================================
+ Hits        20604    22893    +2289     
- Misses       8076     8208     +132     
- Partials     1829     1928      +99

Impacted Files	Coverage Δ
internal/cluster/cluster.go	`71.29% <34.06%> (+1.88%)`	⬆️
internal/bminventory/inventory.go	`77.13% <92.85%> (+7.34%)`	⬆️
internal/versions/osimages.go	`90.99% <0.00%> (-1.67%)`	⬇️
internal/common/common.go	`30.76% <0.00%> (-1.32%)`	⬇️
pkg/auth/rhsso_authz_handler.go	`73.12% <0.00%> (-0.18%)`	⬇️
internal/bminventory/inventory_v2_handlers.go	`61.21% <0.00%> (-0.15%)`	⬇️
internal/common/db.go	`8.19% <0.00%> (ø)`
internal/common/validations.go	`0.00% <0.00%> (ø)`
internal/versions/versions.go	`87.87% <0.00%> (+0.30%)`	⬆️
...nternal/controller/controllers/agent_controller.go	`79.08% <0.00%> (+0.38%)`	⬆️
... and 12 more

nmagnezi · 2023-02-12T14:24:26Z

/test edge-lint
/test edge-unit-test

nmagnezi · 2023-02-12T14:27:52Z

/test edge-lint
/test edge-unit-test

nmagnezi · 2023-02-12T17:28:09Z

/assign @eranco74
/assign @omertuc
/assign @tsorya

openshift-ci-robot · 2023-02-12T17:47:37Z

openshift-ci-robot · 2023-02-12T17:47:39Z

openshift-ci-robot · 2023-02-12T17:47:41Z

openshift-ci-robot · 2023-02-12T17:47:44Z

openshift-ci-robot · 2023-02-12T17:47:52Z

openshift-ci-robot · 2023-02-12T17:47:54Z

nmagnezi · 2023-02-13T12:02:03Z

cluster logs example from ci/prow/edge-e2e-metal-assisted artifacts: cluster_1dc45877-8624-47ea-a102-a8dd2a31e0d8_logs.tar

omertuc · 2023-02-13T12:03:55Z

The extensions for each individual host tar inside that tar is .tar.gz but in reality they're all uncompressed .tar archives

Several changes in how we package logs: 1. Host logs will include host and boot logs under a single file. 2. Cluster logs will now include the host tar.gz file containing the content mentioned in openshift#1. 3. The option to download node-boot logs only is disabled.

nmagnezi · 2023-02-13T12:56:11Z

The extensions for each individual host tar inside that tar is .tar.gz but in reality they're all uncompressed .tar archives

Fixed.

nmagnezi · 2023-02-14T11:49:27Z

/assign @filanov

eranco74 · 2023-02-14T11:57:06Z

Is there a pending PR to fix the signatures in assisted-installer-deployment?

nmagnezi · 2023-02-16T12:22:58Z

Is there a pending PR to fix the signatures in assisted-installer-deployment?

@eranco74 yes: openshift-assisted/assisted-installer-deployment#349

nmagnezi · 2023-02-20T08:09:58Z

/hold until openshift-assisted/assisted-installer-deployment#349 gets merged

nmagnezi · 2023-02-20T09:09:45Z

/unhold
openshift-assisted/assisted-installer-deployment#349 got merged

eranco74 · 2023-02-20T09:27:48Z

/lgtm

openshift-ci · 2023-02-20T11:50:12Z

@nmagnezi: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

slaviered · 2023-02-21T10:02:34Z

internal/bminventory/inventory.go

@@ -3987,6 +3985,14 @@ func (b *bareMetalInventory) prepareClusterLogs(ctx context.Context, cluster *co
 	return fileName, nil
 }

+func (b *bareMetalInventory) preparHostLogs(ctx context.Context, cluster *common.Cluster, host *models.Host) (string, error) {


Why do you need this function at all? It is just a 1:1 wrapper over the inner function?

slaviered · 2023-02-21T10:24:05Z

@nmagnezi So now logs_info also report on the boot logs? that will insure that the user will get a notice if he want to reset the installation where not all logs are packaged yet

) Several changes in how we package logs: 1. Host logs will include host and boot logs under a single file. 2. Cluster logs will now include the host tar.gz file containing the content mentioned in #1. 3. The option to download node-boot logs only is disabled.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 9, 2023

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 9, 2023

openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 9, 2023

openshift-ci bot added the api-review Categorizes an issue or PR as actively needing an API review. label Feb 9, 2023

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2023

nmagnezi force-pushed the MGMT-13454_host_and_boot_logs branch from e73267b to f0b833c Compare February 12, 2023 14:23

openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 12, 2023

nmagnezi force-pushed the MGMT-13454_host_and_boot_logs branch from f0b833c to 22dedac Compare February 12, 2023 14:27

nmagnezi marked this pull request as ready for review February 12, 2023 17:23

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 12, 2023

openshift-ci bot requested review from eliorerz and eranco74 February 12, 2023 17:24

openshift-ci bot assigned eranco74, omertuc and tsorya Feb 12, 2023

nmagnezi force-pushed the MGMT-13454_host_and_boot_logs branch from 22dedac to 00daeb8 Compare February 13, 2023 06:55

nmagnezi force-pushed the MGMT-13454_host_and_boot_logs branch from 00daeb8 to c5e83ca Compare February 13, 2023 12:53

openshift-ci bot assigned filanov Feb 14, 2023

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 20, 2023

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 20, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2023

openshift-merge-robot merged commit f453bb3 into openshift:master Feb 20, 2023

slaviered reviewed Feb 21, 2023

View reviewed changes

MGMT-13454: Group Host and boot logs to a single tarball #4975

MGMT-13454: Group Host and boot logs to a single tarball #4975

Conversation

nmagnezi commented Feb 9, 2023 • edited Loading

List all the issues related to this PR

What environments does this code impact?

How was this code tested?

Checklist

Reviewers Checklist

openshift-ci-robot commented Feb 9, 2023 • edited by openshift-ci bot Loading

List all the issues related to this PR

What environments does this code impact?

How was this code tested?

Checklist

Reviewers Checklist

openshift-ci bot commented Feb 9, 2023

nmagnezi commented Feb 9, 2023

openshift-ci bot commented Feb 9, 2023

openshift-ci bot commented Feb 9, 2023

nmagnezi commented Feb 9, 2023

codecov bot commented Feb 9, 2023 • edited Loading

Codecov Report

nmagnezi commented Feb 12, 2023

nmagnezi commented Feb 12, 2023

nmagnezi commented Feb 12, 2023

openshift-ci-robot commented Feb 12, 2023 • edited by openshift-ci bot Loading

List all the issues related to this PR

What environments does this code impact?

How was this code tested?

Checklist

Reviewers Checklist

openshift-ci-robot commented Feb 12, 2023 • edited by openshift-ci bot Loading

List all the issues related to this PR

What environments does this code impact?

How was this code tested?

Checklist

Reviewers Checklist

openshift-ci-robot commented Feb 12, 2023 • edited by openshift-ci bot Loading

List all the issues related to this PR

What environments does this code impact?

How was this code tested?

Checklist

Reviewers Checklist

openshift-ci-robot commented Feb 12, 2023 • edited by openshift-ci bot Loading

List all the issues related to this PR

What environments does this code impact?

How was this code tested?

Checklist

Reviewers Checklist

openshift-ci-robot commented Feb 12, 2023 • edited by openshift-ci bot Loading

List all the issues related to this PR

What environments does this code impact?

How was this code tested?

Checklist

Reviewers Checklist

openshift-ci-robot commented Feb 12, 2023 • edited by openshift-ci bot Loading

List all the issues related to this PR

What environments does this code impact?

How was this code tested?

Checklist

Reviewers Checklist

nmagnezi commented Feb 13, 2023

omertuc commented Feb 13, 2023

nmagnezi commented Feb 13, 2023

nmagnezi commented Feb 14, 2023

eranco74 commented Feb 14, 2023

nmagnezi commented Feb 16, 2023

nmagnezi commented Feb 20, 2023

nmagnezi commented Feb 20, 2023

eranco74 commented Feb 20, 2023

openshift-ci bot commented Feb 20, 2023

slaviered Feb 21, 2023

Choose a reason for hiding this comment

slaviered commented Feb 21, 2023

nmagnezi commented Feb 9, 2023 •

edited

Loading

openshift-ci-robot commented Feb 9, 2023 •

edited by openshift-ci bot

Loading

codecov bot commented Feb 9, 2023 •

edited

Loading

openshift-ci-robot commented Feb 12, 2023 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Feb 12, 2023 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Feb 12, 2023 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Feb 12, 2023 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Feb 12, 2023 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Feb 12, 2023 •

edited by openshift-ci bot

Loading