NO-ISSUE: Pin gocov version #924
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@danmanor: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
size/XS
|
/remove-label downstream-change-needed |
openshift-ci
bot
removed
the
downstream-change-needed
|
/override ci/prow/edge-e2e-metal-assisted-cnv-4-16 ci/prow/edge-e2e-metal-assisted-odf-4-16 ci/prow/edge-e2e-ai-operator-ztp ci/prow/edge-e2e-metal-assisted ci/prow/e2e-agent-compact-ipv4 |
|
@danmanor: Overrode contexts on behalf of danmanor: ci/prow/e2e-agent-compact-ipv4, ci/prow/edge-e2e-ai-operator-ztp, ci/prow/edge-e2e-metal-assisted, ci/prow/edge-e2e-metal-assisted-cnv-4-16, ci/prow/edge-e2e-metal-assisted-odf-4-16 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danmanor, paul-maidment The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-ocm-2.12 |
|
@danmanor: once the present PR merges, I will cherry-pick it on top of release-ocm-2.12 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-ocm-2.11 |
|
@danmanor: once the present PR merges, I will cherry-pick it on top of release-ocm-2.11 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-ocm-2.10 |
|
@danmanor: once the present PR merges, I will cherry-pick it on top of release-ocm-2.10 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-ocm-2.9 |
|
@danmanor: once the present PR merges, I will cherry-pick it on top of release-ocm-2.9 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #924 +/- ##
=======================================
Coverage 55.19% 55.19%
=======================================
Files 15 15
Lines 3279 3279
=======================================
Hits 1810 1810
Misses 1290 1290
Partials 179 179 |
|
@danmanor: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@danmanor: new pull request created: #925 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@danmanor: new pull request created: #926 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@danmanor: new pull request created: #927 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@danmanor: new pull request created: #928 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-agent-installer-orchestrator |
|
[ART PR BUILD NOTIFIER] Distgit: ose-agent-installer-csr-approver |
…33.0 (#989) * NO-ISSUE: Pin gocov version (#924) * NO-ISSUE: Update Dockerfile to use `go.uber.org/mock` (#911) The change to use `go.uber.org/mock` instead of the deprecated `github.com/golang/mock` was was mostly done in the past. But the _Dockerfile_ wasn't updated to use the new `mockgen` command. As a result if one installs the `mockgen` with the command from the dockerfile and then runs `make generate` the resulting code doesn't build: ``` $ grep mockgen Dockerfile.assisted-installer-build go install github.com/golang/mock/[email protected] && \ $ go install github.com/golang/mock/[email protected] $ make generate go generate .. make format make[1]: Entering directory '/files/projects/assisted-installer/repository' make[1]: Leaving directory '/files/projects/assisted-installer/repository' $ make build CGO_ENABLED=0 go build -o build/installer src/main/main.go src/main/drymock/dry_mode_k8s_mock.go:308:36: cannot use mockController (variable of type *"go.uber.org/mock/gomock".Controller) as *"github.com/golang/mock/gomock".Controller value in argument to k8s_client.NewMockK8SClient make: *** [Makefile:68: installer] Error 1 ``` To avoid this issue this patch updates the _Dockerfile_ to use the `go.uber.org/mock` package. There are also some minor white space changes introduced by running `go generate`. Signed-off-by: Juan Hernandez <[email protected]> * [release-4.17] MGMT-19537: Bump golang.org/x/net to 0.33.0 Remove pin on golang.org/x/net --------- Signed-off-by: Juan Hernandez <[email protected]> Co-authored-by: Dan Manor <[email protected]> Co-authored-by: Juan Hernández <[email protected]>
Same as openshift/assisted-service#6902