-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ImagePolicyList and ClusterImagePolicyList to scheme known types #1726
Conversation
Hello @QiWang19! Some important instructions when contributing to openshift/api: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed the raw types as well
config/v1alpha1/register.go
Outdated
&ImagePolicyList{}, | ||
&ClusterImagePolicyList{}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
&ImagePolicyList{}, | |
&ClusterImagePolicyList{}, | |
&ImagePolicy{}, | |
&ImagePolicyList{}, | |
&ClusterImagePolicy{}, | |
&ClusterImagePolicyList{}, |
Signed-off-by: Qi Wang <[email protected]>
9974974
to
25e03a3
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed, QiWang19 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@QiWang19: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
412e126
into
openshift:master
[ART PR BUILD NOTIFIER] This PR has been included in build ose-cluster-config-api-container-v4.16.0-202401141455.p0.g412e126.assembly.stream for distgit ose-cluster-config-api. |
#1457 did not add ImagePolicyList and ClusterImagePolicyList to scheme known types, led to error
no kind "ClusterImagePolicyList" is registered for version "config.openshift.io/v1alpha1" in scheme
.