Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SigstoreImageVerification feature gate #1470

Merged
merged 1 commit into from
May 25, 2023
Merged

Add SigstoreImageVerification feature gate #1470

merged 1 commit into from
May 25, 2023

Conversation

saschagrunert
Copy link
Member

Adding a feature gate as part of the EPIC OCPNODE-1628

cc @QiWang19 @mrunalp

Refers to enhancement openshift/enhancements#1402

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 25, 2023

Hello @saschagrunert! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 25, 2023
mrunalp
mrunalp reviewed May 25, 2023
View reviewed changes
config/v1/feature_gates.go Outdated
@@ -202,4 +202,14 @@ var (
ResponsiblePerson: "miciah",
OwningProduct: ocpSpecific,
}

FeatureGateImagePolicy = FeatureGateName("ImagePolicy")
Copy link
Member

@mrunalp mrunalp May 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we make it more descriptive, perhaps SigstoreImageVerification

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, changed as suggested.

@saschagrunert saschagrunert changed the title Add ImagePolicy feature gate Add SigstoreImageVerification feature gate May 25, 2023
@deads2k
Copy link
Contributor

deads2k commented May 25, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 25, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 25, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 25, 2023

@saschagrunert: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 8405973 into openshift:master May 25, 2023
@saschagrunert saschagrunert deleted the image-policy branch May 26, 2023 06:17
@QiWang19 QiWang19 mentioned this pull request Oct 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp mrunalp left review comments

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saschagrunert @deads2k @mrunalp @openshift-merge-robot