Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SRO Lab with examples #292

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Add SRO Lab with examples #292

merged 1 commit into from
Aug 9, 2022

Conversation

enriquebelarte
Copy link

Lab folder includes different examples on how to install, build and deploy kernel modules using Special Resource Operator.

@openshift-ci openshift-ci bot requested review from pmtk and qbarrand August 9, 2022 08:29
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 9, 2022
@openshift-ci
Copy link

openshift-ci bot commented Aug 9, 2022

Hi @enriquebelarte. Thanks for your PR.

I'm waiting for a openshift-psap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@enriquebelarte
Copy link
Author

/assign @qbarrand

Copy link
Collaborator

@qbarrand qbarrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly opinionated formatting comments. Thank you for the great lab.

lab/README.md Outdated Show resolved Hide resolved
lab/README.md Outdated Show resolved Hide resolved
lab/README.md Outdated Show resolved Hide resolved
lab/README.md Outdated Show resolved Hide resolved
lab/README.md Outdated Show resolved Hide resolved
lab/README.md Outdated Show resolved Hide resolved
lab/README.md Outdated Show resolved Hide resolved
lab/README.md Outdated Show resolved Hide resolved
lab/README.md Outdated Show resolved Hide resolved
lab/README.md Outdated Show resolved Hide resolved
@enriquebelarte
Copy link
Author

Thank you for the good comments @qbarrand

Copy link
Collaborator

@qbarrand qbarrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last pass 🙂

lab/README.md Outdated Show resolved Hide resolved
lab/README.md Outdated Show resolved Hide resolved
lab/README.md Outdated Show resolved Hide resolved
lab/README.md Outdated Show resolved Hide resolved
lab/README.md Outdated Show resolved Hide resolved
@qbarrand
Copy link
Collaborator

qbarrand commented Aug 9, 2022

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 9, 2022
Fix markdown and syntax mistakes

Fix markdown and syntax mistakes #2

Fix markdown format #3

Fix markdown format #4
@qbarrand
Copy link
Collaborator

qbarrand commented Aug 9, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2022
@qbarrand
Copy link
Collaborator

qbarrand commented Aug 9, 2022

/approve

@openshift-ci
Copy link

openshift-ci bot commented Aug 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enriquebelarte, qbarrand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2022
@openshift-merge-robot openshift-merge-robot merged commit 165497b into openshift-psap:master Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants