-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Microshift_4.12_RHEL_8.7 #2
Open
dfeddema
wants to merge
42
commits into
main
Choose a base branch
from
microshift_4.12_RHEL_8.7
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A number of changes, to focus on Microshift: * Installation of Microshift is considered done by following official docs * We don't install podman, since pods will run with Microshift * The container runtime toolkit is straight forward, but still requires SELinux config * The device plugin instantiation doesn't use the file from NVIDIA as it misses some pieces * The test pod requires some security context adjustments in OCP 4.12 Signed-off-by: Fabien Dupont <[email protected]>
Variant by Fabien Dupont
dfeddema
commented
Jan 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add missing quote to oc get node -o json | jq -r '.items[0].status.capacity'
Following the merge of [nvidia/kubernetes/device-plugin#241](https://gitlab.com/nvidia/kubernetes/device-plugin/-/merge_requests/241), I have simplified the steps for the deployment of the device plugin. While testing it end-to-end, I noticed that some of the SELinux steps were not necessary, so I removed them. Signed-off-by: Fabien Dupont <[email protected]>
Updates after MR241 has been merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed link to MicroShift Installation Instructions.