Fix Commandline help for Results #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix Commandline option for results. Added annotations.
khrm
commented
May 8, 2023
|
cc: @chmouel could you please take a look at this one, opc results was not showing the commands correctly complete discussion (#55 (comment)) , then we found out that we need to add an annotation in tkn-results, so now this PR point to that version of results. |
|
we are going to need some basic smoke test for opc, because I am not sure if it actually works... |
|
you mean if |
|
yes, |
It was working fine just not showing the commands properly, @khrm has also tested it |
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the Commandline option for results. Added annotations to tkn results.