Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix opc pac command to show the help message #40

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Fix opc pac command to show the help message #40

merged 1 commit into from
Mar 2, 2023

Conversation

pratap0007
Copy link
Contributor

This patch will fix opc pac command to show the help message
previously it was failing with an error

vdemeester
vdemeester approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @chmouel

@chmouel
Copy link
Member

chmouel commented Mar 2, 2023

we need a e2e for that, @pratap0007 would you like to contribute it ? just having it to start the help and check if the output is kinda right, over a shell script is fine..

(pr look good, thanks for the fix)

@chmouel chmouel merged commit 4eaf68d into openshift-pipelines:main Mar 2, 2023
@pratap0007
Copy link
Contributor Author

we need a e2e for that, @pratap0007 would you like to contribute it ? just having it to start the help and check if the output is kinda right, over a shell script is fine..

(pr look good, thanks for the fix)

Yes, I would like to contribute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pratap0007 @chmouel @vdemeester