This repository has been archived by the owner on Mar 23, 2020. It is now read-only.
Ipv6 non virtual ip fix #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In IPv6 DHCPv6 environments, the prefix for the IPv6 address that we must use to bind services may be 128. In case that happens, the current detection code will fail to consider the address as being in the right subnet. Thankfully, thanks to the Route Advertisements, we get the prefix information we need from the routing table. This patch adds the extra code to generate pseudo CIDRs that allow us to check if an address is in the right subnet. Signed-off-by: Antoni Segura Puimedon <[email protected]>
This patch simplifies filtering by: * Calling iface_cidrs only once, * Filtering out IPv6 addresses marked with the *deprecated* flag * Allowing multiple filters Signed-off-by: Antoni Segura Puimedon <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of openshift#1436 to the 4.3-ipv6 branch
I've tested this locally and it resolves the problem with prepending the non-virtual IP to the resolv.conf on the worker nodes.