Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-31824: Improve condition messages on backup cleanup failures #735

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jc-rh
Copy link
Member

@jc-rh jc-rh commented Feb 5, 2025

Background / Context

When backup cleanup times out, the IBU condition message is not clear on what manual cleanup could be done:

failed to cleanup backups: failed to delete backups: context deadline exceeded Perform cleanup manually then add 'lca.openshift.io/manual-cleanup-done' annotation to ibu CR to transition back to Idle

Issue / Requirement / Reason for change

Condition message should be more explicit on what exactly timed out

Solution / Feature Overview

The message now reads failed to cleanup backups: timed out on waiting for DeleteBackupRequests to be processed and deleted. Perform cleanup manually then add 'lca.openshift.io/manual-cleanup-done' annotation to ibu CR to transition back to Idle

Implementation Details

Other Information

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 5, 2025
Copy link
Contributor

openshift-ci bot commented Feb 5, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot
Copy link

@jc-rh: This pull request references Jira Issue OCPBUGS-31824, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Background / Context

Issue / Requirement / Reason for change

Solution / Feature Overview

Implementation Details

Other Information

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Feb 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jc-rh. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

@jc-rh: This pull request references Jira Issue OCPBUGS-31824, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yliu127

In response to this:

Background / Context

When backup cleanup times out, the IBU condition message is not clear on what manual cleanup could be done:

failed to cleanup backups: failed to delete backups: context deadline exceeded Perform cleanup manually then add 'lca.openshift.io/manual-cleanup-done' annotation to ibu CR to transition back to Idle

Issue / Requirement / Reason for change

Condition message should be more explicit on what exactly timed out

Solution / Feature Overview

Instead of failed to delete backups: context deadline exceeded, the message now reads timed out on waiting for DeleteBackupRequests to be processed and deleted.

Implementation Details

Other Information

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from yliu127 February 5, 2025 18:03
@openshift-ci-robot
Copy link

@jc-rh: This pull request references Jira Issue OCPBUGS-31824, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yliu127

In response to this:

Background / Context

When backup cleanup times out, the IBU condition message is not clear on what manual cleanup could be done:

failed to cleanup backups: failed to delete backups: context deadline exceeded Perform cleanup manually then add 'lca.openshift.io/manual-cleanup-done' annotation to ibu CR to transition back to Idle

Issue / Requirement / Reason for change

Condition message should be more explicit on what exactly timed out

Solution / Feature Overview

Instead of failed to delete backups: context deadline exceeded, the message now reads timed out on waiting for DeleteBackupRequests to be processed and deleted.

Implementation Details

Other Information

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jc-rh jc-rh marked this pull request as ready for review February 6, 2025 15:21
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 6, 2025
@openshift-ci openshift-ci bot requested review from browsell and sakhoury February 6, 2025 15:21
@jc-rh
Copy link
Member Author

jc-rh commented Feb 6, 2025

/test ci/prow/integration

Copy link
Contributor

openshift-ci bot commented Feb 6, 2025

@jc-rh: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test ci-index
/test ci-job
/test images
/test integration
/test markdownlint

The following commands are available to trigger optional jobs:

/test ibi-e2e-flow
/test ibu-e2e-flow
/test security

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-kni-lifecycle-agent-main-ci-index
pull-ci-openshift-kni-lifecycle-agent-main-ci-job
pull-ci-openshift-kni-lifecycle-agent-main-ibi-e2e-flow
pull-ci-openshift-kni-lifecycle-agent-main-ibu-e2e-flow
pull-ci-openshift-kni-lifecycle-agent-main-images
pull-ci-openshift-kni-lifecycle-agent-main-integration
pull-ci-openshift-kni-lifecycle-agent-main-security

In response to this:

/test ci/prow/integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jc-rh
Copy link
Member Author

jc-rh commented Feb 6, 2025

/test integration

@jc-rh
Copy link
Member Author

jc-rh commented Feb 7, 2025

/retest

@sudomakeinstall2
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2025
@browsell
Copy link
Collaborator

browsell commented Feb 7, 2025

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 7, 2025
@openshift-ci-robot
Copy link

@jc-rh: This pull request references Jira Issue OCPBUGS-31824, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yliu127

In response to this:

Background / Context

When backup cleanup times out, the IBU condition message is not clear on what manual cleanup could be done:

failed to cleanup backups: failed to delete backups: context deadline exceeded Perform cleanup manually then add 'lca.openshift.io/manual-cleanup-done' annotation to ibu CR to transition back to Idle

Issue / Requirement / Reason for change

Condition message should be more explicit on what exactly timed out

Solution / Feature Overview

Instead of failed to delete backups: context deadline exceeded, the message now reads failed to cleanup backups: timed out on waiting for DeleteBackupRequests to be processed and deleted. Perform cleanup manually then add 'lca.openshift.io/manual-cleanup-done' annotation to ibu CR to transition back to Idle

Implementation Details

Other Information

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

@jc-rh: This pull request references Jira Issue OCPBUGS-31824, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yliu127

In response to this:

Background / Context

When backup cleanup times out, the IBU condition message is not clear on what manual cleanup could be done:

failed to cleanup backups: failed to delete backups: context deadline exceeded Perform cleanup manually then add 'lca.openshift.io/manual-cleanup-done' annotation to ibu CR to transition back to Idle

Issue / Requirement / Reason for change

Condition message should be more explicit on what exactly timed out

Solution / Feature Overview

The message now reads failed to cleanup backups: timed out on waiting for DeleteBackupRequests to be processed and deleted. Perform cleanup manually then add 'lca.openshift.io/manual-cleanup-done' annotation to ibu CR to transition back to Idle

Implementation Details

Other Information

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants