ztp: Add a local registry to the SNO DU profile (CNF-3759)

[pixelsoccupied]

A SNO DU can have limited BW between the centralized registry and itself. This can lead to long image download times. This is unavoidable for the initial deployment. For subsequent pulls of an image we are relying on the fact that the image would be in the cache. There is the possibility that it could have been evicted but this would be the exception vs the rule.

Unfortunately this strategy is flawed as crio will wipe /var/lib/containers/storage in the case on an unclean shutdown

To address this, a local registry will be required on the SNO. The cluster images would need to be mirrored to the this registry along with being used as the regisrty for the applications.

[pixelsoccupied]

/cc @browsell @imiller0 @lack

[pixelsoccupied]

Let me know if there's a better place to put these file in.

[browsell]

We want these CR's to be generated automatically by siteconfig and applied as part of the installation. The siteconfig should take the device and partition size as parameters and generate the required CRs

[pixelsoccupied]

Ah so something like how we generate CRs for say BMH? So that would be a new feature of the code base that parses the SiteConfig CR?

[lack]

Basically, expand the SiteConfig CRD with a way to specify additional disk partitions.

Question: for standard clusters, would a customer want to specify different partitioning for masters vs workers?

[pixelsoccupied]

Going to remove the code and rely on templating instead

[lack]

My only other comment, besides the question about the go module changes, would be that we should streamline the git history here before it's merged too, please!

[pixelsoccupied]

/retest-required

[lack]

/lgtm
/retest

[imiller0]

/retest

[lack]

/override ci/prow/e2e-gcp-ovn

These changes do not have anything to do with SRO which is causing the failures.

[openshift-ci]

@lack: Overrode contexts on behalf of lack: ci/prow/e2e-gcp-ovn

In response to this:

/override ci/prow/e2e-gcp-ovn

These changes do not have anything to do with SRO which is causing the failures.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lack]

/approve

[lack]

Ah, we need approval from someone on the go.mod changes too before this can merge.

[pixelsoccupied]

/assign @fromanirh

[ffromani]

/approve
the go.mod changes seems straightforward
trusting you folks for the content review

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fromanirh, lack, pixelsoccupied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [fromanirh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pixelsoccupied]

/cherrypick 4.10

[openshift-cherrypick-robot]

@pixelsoccupied: cannot checkout 4.10: error checking out 4.10: exit status 1. output: error: pathspec '4.10' did not match any file(s) known to git

In response to this:

/cherrypick 4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pixelsoccupied]

/cherrypick release-4.10

[openshift-cherrypick-robot]

@pixelsoccupied: #939 failed to apply on top of branch "release-4.10":

Applying: ztp: Add a local registry to the SNO DU profile (CNF-3759)
.git/rebase-apply/patch:65: trailing whitespace.
   
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M	go.mod
M	ztp/policygenerator-kustomize-plugin/testPolicyGenTemplate/site-du-sno-1-ranGen.yaml
M	ztp/siteconfig-generator-kustomize-plugin/testSiteConfig/site1-sno-du.yaml
M	ztp/siteconfig-generator/siteConfig/siteConfig.go
M	ztp/siteconfig-generator/siteConfig/siteConfigBuilder_test.go
M	ztp/siteconfig-generator/siteConfig/siteConfig_test.go
M	ztp/siteconfig-generator/siteConfig/testdata/siteConfigTestOutput.yaml
Falling back to patching base and 3-way merge...
Auto-merging ztp/siteconfig-generator/siteConfig/testdata/siteConfigTestOutput.yaml
CONFLICT (content): Merge conflict in ztp/siteconfig-generator/siteConfig/testdata/siteConfigTestOutput.yaml
Auto-merging ztp/siteconfig-generator/siteConfig/siteConfig_test.go
CONFLICT (content): Merge conflict in ztp/siteconfig-generator/siteConfig/siteConfig_test.go
Auto-merging ztp/siteconfig-generator/siteConfig/siteConfigBuilder_test.go
Auto-merging ztp/siteconfig-generator/siteConfig/siteConfig.go
CONFLICT (content): Merge conflict in ztp/siteconfig-generator/siteConfig/siteConfig.go
Auto-merging ztp/siteconfig-generator-kustomize-plugin/testSiteConfig/site1-sno-du.yaml
Auto-merging ztp/policygenerator-kustomize-plugin/testPolicyGenTemplate/site-du-sno-1-ranGen.yaml
CONFLICT (content): Merge conflict in ztp/policygenerator-kustomize-plugin/testPolicyGenTemplate/site-du-sno-1-ranGen.yaml
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 ztp: Add a local registry to the SNO DU profile (CNF-3759)
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.