This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
Fix crds for tilt after CRDS moved in #5065 #5100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Sturtevant <[email protected]>
jsturtevant
requested review from
shashankram,
snehachhabria,
nojnhuh,
draychev,
jaellio,
trstringer,
keithmattix and
steeling
as code owners
jsturtevant
changed the title
steeling
approved these changes
Sep 7, 2022
keithmattix
approved these changes
Sep 7, 2022
Codecov Report
@@ Coverage Diff @@
## main #5100 +/- ##
==========================================
+ Coverage 69.57% 69.75% +0.18%
==========================================
Files 199 199
Lines 15400 15591 +191
==========================================
+ Hits 10715 10876 +161
- Misses 4629 4658 +29
- Partials 56 57 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Just tried this out and it works perfectly! Thanks @jsturtevant |
whitneygriffith
pushed a commit
to whitneygriffith/osm
that referenced
this pull request
Sep 12, 2022
Signed-off-by: James Sturtevant <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: James Sturtevant [email protected]
Description:
After moving the CRDs install and dropping the bootstrap init container tilt broke. This fixes that by copy the files to the tilt image.
Testing done:
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project?
Is this a breaking change?
Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)?