Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

ref(pkg/smi): remove unused kubeClient from smi client #4643

Merged

Conversation

fristonio
Copy link
Contributor

Description:

This PR removes the unused kubeClient from SMI client in pkg/smi/client.go.
Found while navigating the source code.

Testing done:

Existing unit tests in client_tests.go should be enough for the changeset.

Affected area:

Functional Area
New Functionality [ ]
CI System [ ]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [ ]
Demo [ ]
Documentation [ ]
Egress [ ]
Ingress [ ]
Install [ ]
Networking [ ]
Observability [ ]
Performance [ ]
SMI Policy [ ]
Security [ ]
Sidecar Injection [ ]
Tests [ ]
Upgrade [ ]
Other [ x ]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project?
    • Did you notify the maintainers and provide attribution?

Not inspired by any external source code.

  1. Is this a breaking change?

No

  1. Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)?

No need for a documentation change, internal refactoring of SMI client.

Copy link
Contributor

@nojnhuh nojnhuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @fristonio!

Copy link
Contributor

@trstringer trstringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

@trstringer trstringer merged commit 95a898f into openservicemesh:main Apr 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants